Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 948943004: Handle ffunction-sections w/ filetype=obj. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle ffunction-sections w/ filetype=obj. Just create a new section of the appropriate name, instead of trying to reuse the .text section. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4080 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cb165ca39e2606d524ab7fcf3f301ac4e468bb69

Patch Set 1 #

Patch Set 2 : fix comment #

Total comments: 2

Patch Set 3 : review #

Patch Set 4 : one dash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -5 lines) Patch
M src/IceELFObjectWriter.cpp View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
A tests_lit/llvm2ice_tests/elf_function_sections.ll View 1 2 3 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-24 02:11:30 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/948943004/diff/20001/src/IceELFObjectWriter.cpp File src/IceELFObjectWriter.cpp (right): https://codereview.chromium.org/948943004/diff/20001/src/IceELFObjectWriter.cpp#newcode221 src/IceELFObjectWriter.cpp:221: bool FunctionSections = Ctx.getFlags().getFunctionSections(); const?
5 years, 10 months ago (2015-02-24 05:09:33 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/948943004/diff/20001/src/IceELFObjectWriter.cpp File src/IceELFObjectWriter.cpp (right): https://codereview.chromium.org/948943004/diff/20001/src/IceELFObjectWriter.cpp#newcode221 src/IceELFObjectWriter.cpp:221: bool FunctionSections = Ctx.getFlags().getFunctionSections(); On 2015/02/24 05:09:32, stichnot wrote: ...
5 years, 10 months ago (2015-02-24 16:50:37 UTC) #4
jvoung (off chromium)
5 years, 10 months ago (2015-02-24 16:53:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
cb165ca39e2606d524ab7fcf3f301ac4e468bb69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698