chromeos/network/onc/onc_signature.cc - Issue 948943003: Better support for Cellular roaming state in ONC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_signature.cc

Issue 948943003: Better support for Cellular roaming state in ONC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_signature.cc

diff --git a/chromeos/network/onc/onc_signature.cc b/chromeos/network/onc/onc_signature.cc

index dddf945582db79609b152e4f6637c4871d996e1e..a4219094a4cf565058a5ea9a26c1c3e371647b94 100644

--- a/chromeos/network/onc/onc_signature.cc

+++ b/chromeos/network/onc/onc_signature.cc

@@ -288,7 +288,6 @@ const OncFieldSignature cellular_with_state_fields[] = {

{ ::onc::cellular::kModelID, &kStringSignature},

{ ::onc::cellular::kNetworkTechnology, &kStringSignature},

{ ::onc::cellular::kPRLVersion, &kIntegerSignature},

- { ::onc::cellular::kProviderRequiresRoaming, &kBoolSignature},

{ ::onc::cellular::kRoamingState, &kStringSignature},

{ ::onc::cellular::kServingOperator, &kCellularProviderSignature},

{ ::onc::cellular::kSignalStrength, &kIntegerSignature},

« no previous file with comments | « chromeos/network/network_util.cc ('k') | chromeos/network/onc/onc_translation_tables.cc » ('j') | no next file with comments »