Chromium Code Reviews Chromium Code Reviews
Issue 948943002:
Gets HTMLIFrameElement::embedViewManagerClient to work with dart (Closed)
Base URL: https://github.com/domokit/mojo.git@master| Index: sky/tests/services/iframe-embed-vmc.sky |
| diff --git a/sky/tests/services/iframe-embed-vmc.sky b/sky/tests/services/iframe-embed-vmc.sky |
| index 7c4a1e1b3ef36f5aa9ee850f29cfcb62c55a239d..cdb98df758aafcd893eedacd1554b938bd8d356f 100644 |
| --- a/sky/tests/services/iframe-embed-vmc.sky |
| +++ b/sky/tests/services/iframe-embed-vmc.sky |
| @@ -1,34 +1,53 @@ |
| -<html> |
| -<import src="/gen/mojo/public/interfaces/application/shell.mojom.sky" as="shellMojom" /> |
| -<import src="/gen/mojo/public/sky/connection.sky" as="connection" /> |
| -<import src="/gen/mojo/public/sky/core.sky" as="core" /> |
| -<import src="/gen/mojo/services/public/sky/shell.sky" as="shellJS" /> |
| -<import src="/gen/services/js/test/echo_service.mojom.sky" as="echoServiceMojom" /> |
| -<import src="/gen/mojo/services/view_manager/public/interfaces/view_manager.mojom.sky" as="ViewManager"> |
| -<import src="/gen/mojo/services/input_events/public/interfaces/input_events.mojom.sky" as="InputEvents"/> |
| -<import src="/sky/framework/sky-element/sky-element.sky" as="SkyElement" /> |
| +<sky> |
| <iframe></iframe> |
| <script> |
| -var shellHandle = internals.takeShellProxyHandle(); |
| -var shellProxy = connection.bindHandleToProxy(shellHandle, shellMojom.Shell); |
| -var shell = new shellJS.Shell(shellProxy); |
| +import 'dart:async'; |
| +import '/mojo/public/dart/application.dart'; |
| +import 'dart:mojo_bindings'; |
| +import 'dart:mojo_core'; |
| +import 'dart:typed_data'; |
| +import 'dart:sky'; |
| +import 'dart:sky.internals' as internals; |
|
abarth-chromium
2015/02/23 22:29:37
Please alphabetize these imports.
|
| -// The vmcApp provides ViewManagerClient and EchoService. |
| -var vmcURL = "http://127.0.0.1:8000/sky/tests/services/resources/iframe-vmc.js" |
| -var vmcApp = shell.connectToApplication(vmcURL); |
| +import 'package:mojo/public/interfaces/application/shell.mojom.dart' as shell_mojom; |
| +import 'package:mojo/services/input_events/public/interfaces/input_events.mojom.dart' as input_events; |
| +import 'package:mojo/services/view_manager/public/interfaces/view_manager.mojom.dart' as view_manager; |
| +import 'package:services/js/test/echo_service.mojom.dart' as echo_service_mojom; |
| -// The Promise returned by the vmcApp's echoString() method will not |
| -// resolve until the vmcApp's onEmbed() method runs. |
| -var echoService = vmcApp.requestService(echoServiceMojom.EchoService); |
| -echoService.echoString("success").then(function(response) { |
| - internals.notifyTestComplete(response.value); |
| -}); |
| +class IFrameEmbed extends Application { |
| + IFrameEmbed.fromHandle(MojoHandle handle) : super.fromHandle(handle); |
| + IFrameEmbed(MojoMessagePipeEndpoint endpoint) : super(endpoint); |
| -// Using internals.connectToService here, instead of just connecting |
| -// with vmcApp, because we just need a MessagePipe handle (not a proxy). |
| -var vmcService = internals.connectToService(vmcURL, ViewManager.ViewManagerClient.name); |
| -document.querySelector("iframe").embedViewManagerClient(vmcService); |
| + void initialize(List<String> args, String url) { |
| + // The vmcApp provides ViewManagerClient and EchoService. |
| + const vmcURL = |
| + "http://127.0.0.1:8000/sky/tests/services/resources/iframe-vmc.js"; |
| + final vmcAppConnection = connectToApplication(vmcURL); |
| + |
| + // The Promise returned by the vmcApp's echoString() method will not |
| + // resolve until the vmcApp's onEmbed() method runs. |
| + final echoService = new echo_service_mojom.EchoServiceProxy.unbound(); |
| + vmcAppConnection.requestService(echoService); |
| + echoService.echoString("success").then((response) { |
| + internals.notifyTestComplete(response.value); |
| + }); |
| + // Using internals.connectToService here, instead of just connecting |
| + // with vmcApp, because we just need a MessagePipe handle (not a proxy). |
| + final vmcService = internals.connectToService( |
| + vmcURL, view_manager.ViewManagerClient.name); |
| + document.querySelector("iframe").embedViewManagerClient(vmcService); |
| + } |
| +} |
| + |
| +main() { |
| + var messagePipe = new MojoMessagePipe(); |
| + var app = new IFrameEmbed(messagePipe.endpoints[1]); |
| + app.listen(); |
| + var shellProxy = new shell_mojom.ShellProxy.fromHandle( |
| + new MojoHandle(internals.takeShellProxyHandle())); |
| + app.initializeFromShellProxy(shellProxy, [], ""); |
| +} |
| </script> |
| -</html> |
| +</sky> |
