Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.cpp

Issue 948943002: Gets HTMLIFrameElement::embedViewManagerClient to work with dart (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/HTMLIFrameElement.cpp
diff --git a/sky/engine/core/html/HTMLIFrameElement.cpp b/sky/engine/core/html/HTMLIFrameElement.cpp
index de92eef7b89ccfd30a06c5a7d182989cdc89340a..c83a6731d4dc082d629d7df0a70dfc3f490823a5 100644
--- a/sky/engine/core/html/HTMLIFrameElement.cpp
+++ b/sky/engine/core/html/HTMLIFrameElement.cpp
@@ -79,14 +79,13 @@ PassRefPtr<DartValue> HTMLIFrameElement::takeExposedServicesHandle(DartState*)
return DartValue::Create();
}
-void HTMLIFrameElement::embedViewManagerClient(DartValue* client) {
+void HTMLIFrameElement::embedViewManagerClient(RefPtr<DartValue> client)
+{
if (!m_contentView)
return;
- // TODO(dart)
- // mojo::MessagePipeHandle handle;
- // if (gin::ConvertFromV8(client.isolate(), client.v8Value(), &handle))
- // m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(mojo::MakeScopedHandle(handle)));
+ m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(
+ DartConverter<mojo::ScopedMessagePipeHandle>::FromDart(client->dart_value())));
}
void HTMLIFrameElement::navigateView()

Powered by Google App Engine
This is Rietveld 408576698