Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 948933003: Roll PDFium (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium This brings in: 28ddd48 Replace second set of #defines with templates in JS_Define.h 94dd28e Update GN build files w/ cpu_arch -> current_cpu changes. dce5730 Add test for PDF's JS "global". a96cc9b Replace ugly JS_Define macros with templates. 2da7bd4 Tidy up JS_Defines.h 7435e8e Run pixel tests via automated script. 83c87e5 run_javascript_tests.py: Be more flexible about directory layout. TBR=jam@chromium.org, tsepez@chromium.org BUG=344767 Committed: https://crrev.com/a2592d89e85232a83f905b679d273444f60b760a Cr-Commit-Position: refs/heads/master@{#317684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Dirk Pranke
5 years, 10 months ago (2015-02-23 22:55:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948933003/1
5 years, 10 months ago (2015-02-23 22:56:29 UTC) #3
Tom Sepez
lgtm
5 years, 10 months ago (2015-02-23 23:00:13 UTC) #4
jam
lgtm
5 years, 10 months ago (2015-02-23 23:55:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 00:12:32 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 00:13:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2592d89e85232a83f905b679d273444f60b760a
Cr-Commit-Position: refs/heads/master@{#317684}

Powered by Google App Engine
This is Rietveld 408576698