LayoutTests/http/tests/security/mime-type-execute-as-html-16.html - Issue 94893003: Support for json media types as (non-image) mime types.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/security/mime-type-execute-as-html-16.html

Issue 94893003: Support for json media types as (non-image) mime types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added DOMImplementation::isJSONMIMEType() and use it to resolve default encodings Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/inspector/network/network-preview-json-type.html ('K') | « LayoutTests/http/tests/inspector/network/resources/json.php ('k') | LayoutTests/http/tests/security/mime-type-execute-as-html-16-expected.txt » ('j') | Source/core/dom/DOMImplementation.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script>	4 <script>

5 if (window.testRunner) {	5 if (window.testRunner) {

6 testRunner.dumpAsText();	6 testRunner.dumpAsText();

7 testRunner.dumpChildFramesAsText();	7 testRunner.dumpChildFramesAsText();

8 }	8 }

9 </script>	9 </script>

10 </head>	10 </head>

11 <body>	11 <body>

12 <p>This test verifies that resources served with a mime type of 'application /json'	12 <p>This test verifies that resources served with a mime type of 'application /x-foo+json'

13 is not rendered as HTML. It passes if no "FAIL: ..." alert is present, and i f the	13 is not rendered as HTML. It passes if no "FAIL: ..." alert is present, and i f the

14 textual content of the frame is visible below.</p>	14 textual content of the frame is visible below.</p>

15 <iframe src="resources/send-mime-types.php?mt=application%2Fjson"></iframe>	15 <iframe src="resources/send-mime-types.php?mt=application%2Fx-foo%2Bjson"></ iframe>
	pfeldman 2013/12/05 17:18:53 Lets leave original here as well. Lets leave original here as well. sof 2013/12/05 19:32:44 Hmm, not sure what you mean. You want the test rem Show quoted text On 2013/12/05 17:18:53, pfeldman wrote: > Lets leave original here as well. Hmm, not sure what you mean. You want the test removed (and not test that the +json media type handling works)? Coalesced with http/tests/security/mime--02.html? pfeldman* 2013/12/06 11:12:29 I just see that you are removing the "resources/se I just see that you are removing the "resources/send-mime-types.php?mt=application%2Fjson" case from the security test, i.e. reducing the coverage. sof 2013/12/06 11:16:16 Isn't that the diff similarity running riot? Show quoted text On 2013/12/06 11:12:29, pfeldman wrote: > I just see that you are removing the > "resources/send-mime-types.php?mt=application%2Fjson" case from the security > test, i.e. reducing the coverage. Isn't that the diff similarity running riot?
16 </body>	16 </body>

17 </html>	17 </html>

OLD	NEW