LayoutTests/http/tests/inspector/network/json-preview.html - Issue 94893003: Support for json media types as (non-image) mime types.

Side by Side Diff: LayoutTests/http/tests/inspector/network/json-preview.html

Issue 94893003: Support for json media types as (non-image) mime types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve test descriptions a bit Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/inspector/network/async-xhr-json-mime-type-expected.txt ('K') | « LayoutTests/http/tests/inspector/network/async-xhr-json-mime-type-expected.txt ('k') | LayoutTests/http/tests/inspector/network/json-preview-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	vsevik 2013/12/16 10:01:19 This is still a 99% copy-paste of another test. It This is still a 99% copy-paste of another test. It think what pfeldman@ suggested you was to create a mock NetworkRequest (e.g. var request = new NetworkRequest(...); request.setMimeType(...)) and test RequestPreviewView with it. sof 2013/12/16 10:35:32 Hmm. We have to test that XHR over JSON types gene Show quoted text On 2013/12/16 10:01:19, vsevik wrote: > This is still a 99% copy-paste of another test. > It think what pfeldman@ suggested you was to create a mock NetworkRequest (e.g. > var request = new NetworkRequest(...); request.setMimeType(...)) and test > RequestPreviewView with it. Hmm. We have to test that XHR over JSON types generates a JSON preview in the network panel. And that the same thing happens for iframes. Why wouldn't you want to load those resources via either XHR and iframes end-to-end to test the outcome? It was broken as-was for iframes; don't think a more focused test would have caught that. That the checking of the outcome in the network panel is similar shouldn't be surprising to anyone. Like many other tests in this directory, it two-steps to fetch content, and dumps out status information in the same manner. cf. network-xhr-sync + network-xhr-async, for instance. I don't want to waste anyone's time, including mine, so what's the issue and requested change here?
	2 <head>

	3 <script src="../inspector-test.js"></script>

	4 <script src="../network-test.js"></script>

	5 <script>

	6 function loadIframe(contentType)

	7 {

	8 iframe = document.createElement("iframe");

	9 iframe.src = "resources/json.php?type=" + contentType;

	10 document.body.appendChild(iframe);

	11 }

	12

	13 function test()

	14 {

	15 InspectorTest.recordNetwork();

	16

	17 var networkPanel = WebInspector.showPanel("network");

	18

	19 function lastRequest()

	20 {

	21 return networkPanel.requests[networkPanel.requests.length - 1];

	22 }

	23

	24 function reportRequest(request)

	25 {

	26 InspectorTest.addResult("request.url: " + request.url);

	27 InspectorTest.addResult("request.type: " + request.type);

	28 InspectorTest.addResult("request.mimeType: " + request.mimeType);

	29 }

	30

	31 function testPreviewer(request)

	32 {

	33 var previewView = new WebInspector.RequestPreviewView(request, null);

	34 var previewer = previewView._createPreviewView();

	35 InspectorTest.addResult("resource.content: " + request.content);

	36 InspectorTest.addResult("Request previewer is JSON: " + (previewer insta nceof WebInspector.RequestJSONView));

	37 }

	38

	39 function testType(contentType, callback)

	40 {

	41 var encodedContentType = encodeURIComponent(contentType);

	42 function step2()

	43 {

	44 var request = lastRequest();

	45 reportRequest(request);

	46 request.requestContent(step3);

	47 }

	48 function step3()

	49 {

	50 var request = lastRequest();

	51 testPreviewer(request);

	52

	53 InspectorTest.addConsoleSniffer(step4);

	54 InspectorTest.evaluateInPage("loadIframe('" + encodedContentType + " ')");

	55 }

	56 function step4()

	57 {

	58 var request = lastRequest();

	59 reportRequest(request);

	60 request.requestContent(step5);

	61 }

	62 function step5()

	63 {

	64 var request = lastRequest();

	65 testPreviewer(request);

	66

	67 callback();

	68 }

	69 InspectorTest.makeSimpleXHR("GET", "resources/json.php?type=" + encodedC ontentType, true, step2);

	70 }

	71 InspectorTest.runTestSuite([

	72 function test1(next)

	73 {

	74 testType("application/json", next);

	75 },

	76 function test2(next)

	77 {

	78 testType("application/vnd.document+json", next);

	79 },

	80 ]);

	81 }

	82 </script>

	83 </head>

	84 <body onload="runTest()">

	85 <p>Tests that resources with JSON MIME types are previewed with the JSON viewer. </p>

	86 </p>

	87 </body>

	88 </html>

OLD	NEW