Enable the syncing of extension and app settings by default.

Enable the syncing of extension and app settings by default.


BUG=114974
TEST=sync_integration_tests --gtest_filter=TwoClientExtensionSettingsAndAppSettingsSyncTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124040

[akalin, 2012-02-28 08:01:42]

What's the story with the UI for this?  Will the appropriate feature be tied to
the Extensions or Apps checkbox?  I don't see any code for that in
sync_prefs.{h,cc}

https://chromiumcodereview.appspot.com/9489002/diff/1/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://chromiumcodereview.appspot.com/9489002/diff/1/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_components_factory_impl.cc:164: // Extension
and app setting sync is disabled by default.  Register unless
disabled -> enabled

https://chromiumcodereview.appspot.com/9489002/diff/1/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_components_factory_impl.cc:170:
pss->RegisterDataTypeController(
please add separate switch for app settings

[not at google - send to devlin, 2012-02-28 08:11:53]

The code that does the disabling the UI is here:

http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/webui/syn...

https://chromiumcodereview.appspot.com/9489002/diff/1/chrome/browser/sync/pro...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://chromiumcodereview.appspot.com/9489002/diff/1/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_components_factory_impl.cc:164: // Extension
and app setting sync is disabled by default.  Register unless
On 2012/02/28 08:01:42, akalin wrote:
> disabled -> enabled

Done.

https://chromiumcodereview.appspot.com/9489002/diff/1/chrome/browser/sync/pro...
chrome/browser/sync/profile_sync_components_factory_impl.cc:170:
pss->RegisterDataTypeController(
On 2012/02/28 08:01:42, akalin wrote:
> please add separate switch for app settings

Done.

[akalin, 2012-02-28 18:25:56]

On 2012/02/28 08:11:53, kalman wrote:
> The code that does the disabling the UI is here:
> 
>
http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/webui/syn...

Ugh, how did that happen?  That's definitely the wrong place.  Can you remove
that code and put it in sync_prefs.{h,cc}, with the other examples (autofill
profile, app notifications)?  I guess it can be in a CL separate from this one.

[akalin, 2012-02-28 18:27:33]

On 2012/02/28 18:25:56, akalin wrote:
> On 2012/02/28 08:11:53, kalman wrote:
> > The code that does the disabling the UI is here:
> > 
> >
>
http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/ui/webui/syn...
> 
> Ugh, how did that happen?  That's definitely the wrong place.  Can you remove
> that code and put it in sync_prefs.{h,cc}, with the other examples (autofill
> profile, app notifications)?  I guess it can be in a CL separate from this
one.

This CL LGTM, I'll check the box.

[commit-bot: I haz the power, 2012-02-28 18:27:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/9489002/6002

[commit-bot: I haz the power, 2012-02-28 22:18:51]

Change committed as 124040