Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 948863002: Get rid of recursive locks for job based recompilation (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get rid of recursive locks for job based recompilation For flushing the input queue, use the input queue lock. Introduce an explicit refcount to make sure we don't delete the thread object before all jobs are finished. BUG=v8:3608 R=yangguo@chromium.org LOG=n Committed: https://crrev.com/2f7c192676b1549889a3b829d829b0b984e17ccd Cr-Commit-Position: refs/heads/master@{#26812}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -46 lines) Patch
M src/flag-definitions.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/optimizing-compiler-thread.h View 2 chunks +3 lines, -8 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 1 2 9 chunks +61 lines, -37 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-23 14:52:32 UTC) #1
Yang
lgtm with comment. https://codereview.chromium.org/948863002/diff/1/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): https://codereview.chromium.org/948863002/diff/1/src/optimizing-compiler-thread.cc#newcode199 src/optimizing-compiler-thread.cc:199: *flag = STOP; I'd prefer having ...
5 years, 10 months ago (2015-02-24 09:57:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948863002/20001
5 years, 10 months ago (2015-02-24 10:07:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948863002/20001
5 years, 10 months ago (2015-02-24 10:07:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/102)
5 years, 10 months ago (2015-02-24 10:11:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/102)
5 years, 10 months ago (2015-02-24 10:11:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948863002/40001
5 years, 10 months ago (2015-02-24 10:20:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948863002/40001
5 years, 10 months ago (2015-02-24 10:20:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-24 10:41:31 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 10:41:53 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2f7c192676b1549889a3b829d829b0b984e17ccd
Cr-Commit-Position: refs/heads/master@{#26812}

Powered by Google App Engine
This is Rietveld 408576698