Mixed Content: Make strict mode stricter.

Mixed Content: Make strict mode stricter.

Strict mode blocks insecure websocket connections, but doesn't do so in
a way that prevents them from signaling to the embedder. We wish to
suppress this signal, as it triggers visible UI in Chrome's omnibox.
This CL cleans up the implementation to make sure that happens.

BUG=450458
R=jww@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190728

[Mike West, 2015-02-23 14:40:26]

Mind taking a look?

[jww, 2015-02-23 18:23:17]

lgtm with nits

https://codereview.chromium.org/948853002/diff/1/LayoutTests/http/tests/secur...
File
LayoutTests/http/tests/security/mixedContent/strict-mode-websocket-blocked.https.html
(right):

https://codereview.chromium.org/948853002/diff/1/LayoutTests/http/tests/secur...
LayoutTests/http/tests/security/mixedContent/strict-mode-websocket-blocked.https.html:9:
<p>This test passes if the image below is treated as blockable content.</p>
'socket' not 'image'?

https://codereview.chromium.org/948853002/diff/1/Source/core/loader/MixedCont...
File Source/core/loader/MixedContentChecker.cpp (right):

https://codereview.chromium.org/948853002/diff/1/Source/core/loader/MixedCont...
Source/core/loader/MixedContentChecker.cpp:332: allowed = !strictMode && true;
Why the '&& true'? Shouldn't !strictMode be sufficient?

[Mike West, 2015-02-24 07:23:54]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-02-24 07:23:55]

The patchset sent to the CQ was uploaded after l-g-t-m from jww@chromium.org
Link to the patchset: https://codereview.chromium.org/948853002/#ps20001 (title:
"Feedback")

[commit-bot: I haz the power, 2015-02-24 07:24:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/948853002/20001

[Mike West, 2015-02-24 07:43:34]

Thanks!

https://codereview.chromium.org/948853002/diff/1/LayoutTests/http/tests/secur...
File
LayoutTests/http/tests/security/mixedContent/strict-mode-websocket-blocked.https.html
(right):

https://codereview.chromium.org/948853002/diff/1/LayoutTests/http/tests/secur...
LayoutTests/http/tests/security/mixedContent/strict-mode-websocket-blocked.https.html:9:
<p>This test passes if the image below is treated as blockable content.</p>
On 2015/02/23 at 18:23:17, jww wrote:
> 'socket' not 'image'?

This shouldn't be here at all, really. `testharness.js` tests choke on newlines.
:/

https://codereview.chromium.org/948853002/diff/1/Source/core/loader/MixedCont...
File Source/core/loader/MixedContentChecker.cpp (right):

https://codereview.chromium.org/948853002/diff/1/Source/core/loader/MixedCont...
Source/core/loader/MixedContentChecker.cpp:332: allowed = !strictMode && true;
On 2015/02/23 at 18:23:17, jww wrote:
> Why the '&& true'? Shouldn't !strictMode be sufficient?

Because I'm an idiot. Thanks!

[commit-bot: I haz the power, 2015-02-24 07:49:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 07:49:56]

Try jobs failed on following builders:
  android_blink_compile_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

[Mike West, 2015-02-24 07:58:25]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-02-24 07:59:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/948853002/20001

[commit-bot: I haz the power, 2015-02-24 08:58:43]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190728