Promise.all and race should work with iterables

Promise.all and race should work with iterables

BUG=v8:3705
LOG=N
R=rossberg@chromium.org

Committed: https://crrev.com/3a8e496fa4c49e35285fa5ea8ea425d627c6b210
Cr-Commit-Position: refs/heads/master@{#26801}

[arv (Not doing code reviews), 2015-02-23 16:39:37]

Cleanup

[arv (Not doing code reviews), 2015-02-23 16:40:39]

arv@chromium.org changed reviewers:
+ domenic@google.com

[arv (Not doing code reviews), 2015-02-23 16:40:40]

PTAL

https://codereview.chromium.org/948843004/diff/20001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/948843004/diff/20001/src/promise.js#newcode312
src/promise.js:312: // Nested scope to get closure over current i (and avoid
.bind).
Andreas, do you think it would make sense to switch to let at  this point?

[rossberg, 2015-02-23 17:38:40]

lgtm

https://codereview.chromium.org/948843004/diff/20001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/948843004/diff/20001/src/promise.js#newcode312
src/promise.js:312: // Nested scope to get closure over current i (and avoid
.bind).
On 2015/02/23 16:40:39, arv wrote:
> Andreas, do you think it would make sense to switch to let at  this point?

Probably. The comment is outdated either way, because after this change, i is no
longer a loop variable. For-let won't help any more, you'd need to use an
explicit let binding in the loop body.

[arv (Not doing code reviews), 2015-02-23 17:42:45]

https://codereview.chromium.org/948843004/diff/20001/src/promise.js
File src/promise.js (right):

https://codereview.chromium.org/948843004/diff/20001/src/promise.js#newcode312
src/promise.js:312: // Nested scope to get closure over current i (and avoid
.bind).
On 2015/02/23 17:38:40, rossberg wrote:
> On 2015/02/23 16:40:39, arv wrote:
> > Andreas, do you think it would make sense to switch to let at  this point?
> 
> Probably. The comment is outdated either way, because after this change, i is
no
> longer a loop variable. For-let won't help any more, you'd need to use an
> explicit let binding in the loop body.

Yup.

I'll make the change... scratch that. Builtins cannot yet use harmony scoping.

[arv (Not doing code reviews), 2015-02-23 17:44:35]

New patchsets have been uploaded after l-g-t-m from rossberg@chromium.org

[arv (Not doing code reviews), 2015-02-23 17:44:36]

Update commment and todo

[arv (Not doing code reviews), 2015-02-23 17:44:48]

I updated the comment at least.

[arv (Not doing code reviews), 2015-02-23 17:44:51]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-02-23 17:45:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/948843004/40001

[commit-bot: I haz the power, 2015-02-23 18:10:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 18:10:09]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-02-23 18:10:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-23 18:10:21]

Patchset 3 (id:??) landed as
https://crrev.com/3a8e496fa4c49e35285fa5ea8ea425d627c6b210
Cr-Commit-Position: refs/heads/master@{#26801}