Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 948843003: Removed partial Client Hints implementation from the Chrome side. (Closed)

Created:
5 years, 10 months ago by Yoav Weiss
Modified:
5 years, 10 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed partial Client Hints implementation from the Chrome side. The first step in adding full Client-Hints support on the Blink side is to delete the partial implementation from the Chrome side. This CL does that. BUG=458983 Committed: https://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f Cr-Commit-Position: refs/heads/master@{#317639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -200 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 3 chunks +0 lines, -12 lines 0 comments Download
D chrome/browser/net/client_hints.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/net/client_hints.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/net/client_hints_unittest.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Yoav Weiss
5 years, 10 months ago (2015-02-23 14:28:56 UTC) #2
Mike West
LGTM! That said, I don't own any of this. Perhaps Jochen can take a look?
5 years, 10 months ago (2015-02-23 14:30:15 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-23 14:42:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948843003/1
5 years, 10 months ago (2015-02-23 14:44:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61608)
5 years, 10 months ago (2015-02-23 14:47:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948843003/1
5 years, 10 months ago (2015-02-23 15:15:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61624)
5 years, 10 months ago (2015-02-23 15:18:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948843003/1
5 years, 10 months ago (2015-02-23 16:24:50 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61664)
5 years, 10 months ago (2015-02-23 16:28:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948843003/1
5 years, 10 months ago (2015-02-23 20:21:35 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 20:22:29 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:23:07 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e20e7611b94ccaeab582fbb829ac2dd83052e4f
Cr-Commit-Position: refs/heads/master@{#317639}

Powered by Google App Engine
This is Rietveld 408576698