Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 948833002: [CSS Grid Layout] Avoid unneeded calls to hasDefiniteLogicalSize() (Closed)

Created:
5 years, 10 months ago by Manuel Rego
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Avoid unneeded calls to hasDefiniteLogicalSize() r189895 was introducing a performance regression on grid layout tests. The problem is that hasDefiniteLogicalSize() is slower than the previous check (logicalSize.isIntrinsicOrAuto()). However, it's not needed to call always hasDefiniteLogicalSize(), only when the values are percentages. Thus, this patch is modifying the logic to only call hasDefiniteLogicalSize() when it's really needed in order to reduce the performance overhead. BUG=457606 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191145

Patch Set 1 #

Patch Set 2 : Rebased patch after LayoutGrid rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M Source/core/layout/LayoutGrid.cpp View 1 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Manuel Rego
5 years, 10 months ago (2015-02-23 11:18:54 UTC) #2
eae
Makes sense to me but I'd like either Julien or Levi to take a look ...
5 years, 10 months ago (2015-02-23 20:01:03 UTC) #3
Julien - ping for review
lgtm
5 years, 9 months ago (2015-03-02 21:26:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948833002/20001
5 years, 9 months ago (2015-03-02 21:28:07 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 23:09:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191145

Powered by Google App Engine
This is Rietveld 408576698