LayoutTests/fast/frames/resources/reparent-iframe.html - Issue 948793003: Fix inconsistent frame detach behavior of ContainerNode::parserRemoveChild.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/frames/resources/reparent-iframe.html

Issue 948793003: Fix inconsistent frame detach behavior of ContainerNode::parserRemoveChild. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/frames/reparented-iframe-cleared-contentWindow.html ('K') | « LayoutTests/fast/frames/reparented-iframe-cleared-contentWindow-expected.txt ('k') | Source/core/dom/ContainerNode.cpp » ('j') | Source/core/dom/Node.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <b><p>

	2 <script>

	3 var body = document.body;

	4 body.remove();

	5 top.reparentedIframe = body.firstChild.firstChild.appendChild(document.createEle ment("iframe"));

	6 document.documentElement.appendChild(body.firstChild);

	7 body = null;
	Yuta Kitamura 2015/02/23 07:54:41 Took some time for me to understand this part; let Took some time for me to understand this part; let me confirm my understanding: this code is doing the following, right? * Detach <body> from the document, * Create an <iframe> and put it in <p>, and * Move <b> back to the document again (so the iframe is hosted in a document for the first time)
	8 </script>

	9 <!-- Force reparenting! -->
	Yuta Kitamura 2015/02/23 07:54:41 This comment seems unhelpful and unnecessary This comment seems unhelpful and unnecessary
	10 </b></p>
	Yuta Kitamura 2015/02/23 07:54:41 Close tag order is wrong Close tag order is wrong
OLD	NEW