Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 948793002: Print tools/perf/run_benchmark list on stdout instead of stderr (Closed)

Created:
5 years, 10 months ago by alancutter (OOO until 2018)
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print tools/perf/run_benchmark list on stdout instead of stderr This patch changes tools/perf/run_benchmark to output the list command on stdout instead of stderr. This makes grepping for benchmarks easier. Note: The run command will still output the benchmark list on stderr if an invalid benchmark is specified. Committed: https://crrev.com/e2988849a05e193adb21091d0f89ba96dd1b65ac Cr-Commit-Position: refs/heads/master@{#317712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M tools/telemetry/telemetry/benchmark_runner.py View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
alancutter (OOO until 2018)
5 years, 10 months ago (2015-02-23 00:47:35 UTC) #2
sullivan
lgtm
5 years, 10 months ago (2015-02-23 14:53:11 UTC) #4
dtu
lgtm Also you can do fuzzy matching, e.g.: run_benchmark list smooth
5 years, 10 months ago (2015-02-23 22:54:12 UTC) #5
alancutter (OOO until 2018)
On 2015/02/23 22:54:12, dtu wrote: > lgtm > > Also you can do fuzzy matching, ...
5 years, 10 months ago (2015-02-23 23:47:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948793002/1
5 years, 10 months ago (2015-02-23 23:52:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 01:07:10 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:08:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2988849a05e193adb21091d0f89ba96dd1b65ac
Cr-Commit-Position: refs/heads/master@{#317712}

Powered by Google App Engine
This is Rietveld 408576698