Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 948763003: Remove chrome_elf from gn check (Closed)

Created:
5 years, 10 months ago by binjin
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chrome_elf from gn check It seems to be caused by bc44c0a95e9904154e2af47fb2dba8c37e169a13, remove the single failing target on Win gn bot. BUG=460828 TBR=brettw@chromium.org Committed: https://crrev.com/41efe080bc89affa24244b1fc5f7cfebb4db43f7 Cr-Commit-Position: refs/heads/master@{#317573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M .gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948763003/1
5 years, 10 months ago (2015-02-23 11:58:04 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61560)
5 years, 10 months ago (2015-02-23 12:00:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948763003/1
5 years, 10 months ago (2015-02-23 12:19:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61568)
5 years, 10 months ago (2015-02-23 12:21:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948763003/1
5 years, 10 months ago (2015-02-23 12:26:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 12:34:56 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/41efe080bc89affa24244b1fc5f7cfebb4db43f7 Cr-Commit-Position: refs/heads/master@{#317573}
5 years, 10 months ago (2015-02-23 12:35:36 UTC) #12
brettw
5 years, 10 months ago (2015-02-23 17:49:37 UTC) #13
Message was sent while issue was closed.
Thanks. LGTM

Powered by Google App Engine
This is Rietveld 408576698