Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: net/http/http_security_headers_unittest.cc

Issue 948733002: Re-enable HttpSecurityHeadersTest.UpdateDynamicPKPMaxAge0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_security_headers_unittest.cc
diff --git a/net/http/http_security_headers_unittest.cc b/net/http/http_security_headers_unittest.cc
index 234c5f076ece48c8bc597cb5f3cf9868ec5334dc..ec8f3f4a53f9e7c96ecd62544a9fb07e48b092f5 100644
--- a/net/http/http_security_headers_unittest.cc
+++ b/net/http/http_security_headers_unittest.cc
@@ -593,13 +593,7 @@ TEST_F(HttpSecurityHeadersTest, UpdateDynamicPKPOnly) {
EXPECT_NE(new_dynamic_domain_state.pkp.spki_hashes.end(), hash);
}
-// Failing on win_chromium_rel. crbug.com/375538
-#if defined(OS_WIN)
-#define MAYBE_UpdateDynamicPKPMaxAge0 DISABLED_UpdateDynamicPKPMaxAge0
-#else
-#define MAYBE_UpdateDynamicPKPMaxAge0 UpdateDynamicPKPMaxAge0
-#endif
-TEST_F(HttpSecurityHeadersTest, MAYBE_UpdateDynamicPKPMaxAge0) {
+TEST_F(HttpSecurityHeadersTest, UpdateDynamicPKPMaxAge0) {
TransportSecurityState state;
TransportSecurityState::DomainState static_domain_state;
@@ -677,7 +671,6 @@ TEST_F(HttpSecurityHeadersTest, MAYBE_UpdateDynamicPKPMaxAge0) {
&failure_log));
EXPECT_NE(0UL, failure_log.length());
}
-#undef MAYBE_UpdateDynamicPKPMaxAge0
// Tests that when a static HSTS and a static HPKP entry are present, adding a
// dynamic HSTS header does not clobber the static HPKP entry. Further, adding a
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698