Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 948603002: Fix resize ACK bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 717e2c018b2c4ddfe192486aeae42725c7c26fda..a130030e9bf9c0372dbc07162ca1f7319c02b595 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -591,7 +591,7 @@ bool RenderWidgetHostImpl::GetResizeParams(
const bool size_changed =
!old_resize_params_ ||
- old_resize_params_->new_size != resize_params->new_size;
+ current_size_ != resize_params->new_size;
bool dirty =
size_changed || screen_info_out_of_date_ ||
old_resize_params_->physical_backing_size !=
@@ -638,6 +638,9 @@ void RenderWidgetHostImpl::WasResized() {
old_resize_params_->new_size.width() != params->new_size.width();
if (Send(new ViewMsg_Resize(routing_id_, *params))) {
resize_ack_pending_ = params->needs_resize_ack;
+ DCHECK_IMPLIES(params->new_size.IsEmpty(), !params->needs_resize_ack);
+ if (params->new_size.IsEmpty())
no sievers 2015/02/26 00:23:06 This is purely to make one of the tests happy whic
+ current_size_ = params->new_size;
old_resize_params_.swap(params);
}
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698