Add more tests for mouse rotation,scale&position after display change

Add more tests for mouse rotation,scale&position after display change

This CL also makes CursorWindowController::SetDisplay() update the cursor
rotation. This is consistent with the behavior of native cursors when
AshNativeCursorManager::SetDisplay() is called.

BUG=450860
TEST=See CL

Committed: https://crrev.com/21a9d207e9e1f861bbd0e33e5b72481e4876a2e1
Cr-Commit-Position: refs/heads/master@{#320173}

[pkotwicz, 2015-02-24 18:14:30]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-02-24 18:29:07]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2015-02-24 18:38:06]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2015-02-24 18:38:08]

Oshima, PTAL

I have added extra tests for the cursor after displays are updated. I have made
these tests separate from https://codereview.chromium.org/902123002/ because the
tests do not test anything related to the bug. (i.e. the tests will not fail
without the CL and pass with it)

I modified CursorWindowController for the sake of
MirrorWindowControllerTest.MirrorCursorMoveOnEnter

There could be half a dozen more tests for CursorWindowController (e.g. the
behavior when entering software mirror mode while cursor compositing is turned
on)
Eventually we will want to have a dedicated CursorWindowControllerTestApi class

https://codereview.chromium.org/948583005/diff/40001/ash/display/display_cont...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/948583005/diff/40001/ash/display/display_cont...
ash/display/display_controller.cc:539: void
DisplayController::UpdateMouseLocationAfterDisplayChange() {
I renamed this method because you mentioned in
https://codereview.chromium.org/902123002/ that this method should be renamed. I
did not want to rename this method and the unittests in a follow up CL

https://codereview.chromium.org/948583005/diff/40001/ash/display/display_cont...
File ash/display/display_controller_unittest.cc (left):

https://codereview.chromium.org/948583005/diff/40001/ash/display/display_cont...
ash/display/display_controller_unittest.cc:964: TEST_F(DisplayControllerTest,
CursorDeviceScaleFactorSwapPrimary) {
This test seems redundant

MouseCursorEventFilterTest.CursorDeviceScaleFactor (existing test) tests that
the mouse cursor's device scale factor is properly updated when moving the
cursor between displays with different device scale factors.

DisplayControllerTest.UpdateMouseLocationAfterDisplayChange_PrimaryDisconnected
(new test)
tests that the mouse cursor's device scale factor is properly updated when the
display it is on is removed

https://codereview.chromium.org/948583005/diff/40001/ash/display/display_mana...
File ash/display/display_manager_unittest.cc (left):

https://codereview.chromium.org/948583005/diff/40001/ash/display/display_mana...
ash/display/display_manager_unittest.cc:704: // Tests that rely on the actual
host size/location does not work on windows.
I moved these to display_controller_unittests.cc

Tests like these would ideally be located in a file named based on what they are
testing not one of the files whose behavior they are testing.

[pkotwicz, 2015-03-08 01:17:25]

Oshima, Ping!

[oshima, 2015-03-09 23:08:20]

sorry for delay. one nit

https://codereview.chromium.org/948583005/diff/40001/ash/display/cursor_windo...
File ash/display/cursor_window_controller.cc (right):

https://codereview.chromium.org/948583005/diff/40001/ash/display/cursor_windo...
ash/display/cursor_window_controller.cc:148: UpdateCursorImage();
can you move the method to private, then you don't need this.

[pkotwicz, 2015-03-10 03:13:05]

Oshima, can you please take another look?

https://codereview.chromium.org/948583005/diff/40001/ash/display/cursor_windo...
File ash/display/cursor_window_controller.cc (right):

https://codereview.chromium.org/948583005/diff/40001/ash/display/cursor_windo...
ash/display/cursor_window_controller.cc:148: UpdateCursorImage();
I don't think I understand your comment.

CursorWindowController::SetDisplay() cannot be private because it is used by
AshNativeCursorManager::SetDisplay().

[oshima, 2015-03-10 19:39:10]

On 2015/03/10 03:13:05, pkotwicz wrote:
> Oshima, can you please take another look?
> 
>
https://codereview.chromium.org/948583005/diff/40001/ash/display/cursor_windo...
> File ash/display/cursor_window_controller.cc (right):
> 
>
https://codereview.chromium.org/948583005/diff/40001/ash/display/cursor_windo...
> ash/display/cursor_window_controller.cc:148: UpdateCursorImage();
> I don't think I understand your comment.
> 
> CursorWindowController::SetDisplay() cannot be private because it is used by
> AshNativeCursorManager::SetDisplay().

Oh, sorry. It didn't show up in cs. lgtm

[pkotwicz, 2015-03-10 20:58:05]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-10 20:58:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/948583005/40001

[commit-bot: I haz the power, 2015-03-10 23:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-10 23:45:38]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2015-03-11 21:30:02]

Patchset #2 (id:60001) has been deleted

[pkotwicz, 2015-03-11 21:56:32]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-03-11 21:56:32]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/948583005/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-03-11 21:58:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/948583005/80001

[commit-bot: I haz the power, 2015-03-11 22:48:25]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2015-03-11 22:49:16]

Patchset 2 (id:??) landed as
https://crrev.com/21a9d207e9e1f861bbd0e33e5b72481e4876a2e1
Cr-Commit-Position: refs/heads/master@{#320173}