Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 948583002: Bindings: Make interface operation (method) properties configurable (Closed)

Created:
5 years, 10 months ago by jsbell
Modified:
5 years, 10 months ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Bindings: Make interface operation properties configurable Per the Web IDL spec [1]: 4.5.8. Operations: "The property has attributes { [[Writable]]: B, [[Enumerable]]: true, [[Configurable]]: B }, where B is false if the operation is unforgeable on the interface, and true otherwise." In other words, Object.getOwnPropertyDescriptor(i.p, 'm') should have configurable: true, except for [Unforgeable] which is already special-cased. [1] http://heycam.github.io/webidl/#es-operations BUG=138217, 377476 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190695

Patch Set 1 #

Patch Set 2 : Tests #

Total comments: 1

Patch Set 3 : Rebaseline newly behaving tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/canvas/philip/tests/type.prototype-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt View 1 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/w3c/webperf/approved/HighResolutionTime/idlharness-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/w3c/webperf/approved/UserTiming/idlharness-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jsbell
https://codereview.chromium.org/948583002/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (left): https://codereview.chromium.org/948583002/diff/20001/LayoutTests/TestExpectations#oldcode1307 LayoutTests/TestExpectations:1307: crbug.com/377476 fast/js/function-name.html [ NeedsManualRebaseline ] These have been disabled ...
5 years, 10 months ago (2015-02-20 23:57:47 UTC) #1
jsbell
Looks promising. The failures are: canvas/philip/tests/type.prototype.html virtual/display_list_2d_canvas/canvas/philip/tests/type.prototype.html virtual/gpu/canvas/philip/tests/type.prototype.html http/tests/w3c/webperf/approved/UserTiming/idlharness.html http/tests/w3c/webperf/approved/HighResolutionTime/idlharness.html ... all of which are ...
5 years, 10 months ago (2015-02-21 03:30:55 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-21 06:59:15 UTC) #3
Jens Widell
LGTM
5 years, 10 months ago (2015-02-21 08:24:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948583002/40001
5 years, 10 months ago (2015-02-23 23:03:13 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 23:16:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190695

Powered by Google App Engine
This is Rietveld 408576698