Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 948543002: Convert crypto::ScopedOpenSSL to type aliases. (Closed)

Created:
5 years, 10 months ago by davidben
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert crypto::ScopedOpenSSL to type aliases. This avoids having to put '::Type' everywhere. BUG=none Committed: https://crrev.com/e94fe096ed8c20a9388c6b321dc20a4b3eaa0a34 Cr-Commit-Position: refs/heads/master@{#317462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -80 lines) Patch
M chrome/common/net/x509_certificate_model_openssl.cc View 12 chunks +16 lines, -16 lines 0 comments Download
M content/child/webcrypto/openssl/aes_cbc_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/openssl/aes_ctr_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/openssl/util_openssl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M crypto/ec_private_key_openssl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M crypto/rsa_private_key_openssl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M crypto/scoped_openssl_types.h View 2 chunks +16 lines, -18 lines 0 comments Download
M crypto/signature_verifier_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/cast/cast_cert_validator_openssl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/base/keygen_handler_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/ct_objects_extractor_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/sha256_legacy_support_openssl_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/cert/x509_certificate_openssl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/cert/x509_util_openssl.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M net/cert/x509_util_openssl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/ssl/scoped_openssl_types.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
davidben
5 years, 10 months ago (2015-02-20 21:48:13 UTC) #2
Ryan Sleevi
lgtm
5 years, 10 months ago (2015-02-20 22:11:14 UTC) #3
davidben
+rockot for extensions/ OWNERS
5 years, 10 months ago (2015-02-20 23:26:03 UTC) #5
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-20 23:34:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948543002/1
5 years, 10 months ago (2015-02-20 23:47:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-21 00:51:41 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:53:24 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e94fe096ed8c20a9388c6b321dc20a4b3eaa0a34
Cr-Commit-Position: refs/heads/master@{#317462}

Powered by Google App Engine
This is Rietveld 408576698