Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 948513004: Revert of Revert of Clip incremental invalidation rects for RenderBox (Closed)

Created:
5 years, 10 months ago by Xianzhu
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Clip incremental invalidation rects for RenderBox (patchset #4 id:160001 of https://codereview.chromium.org/899813004/) Reason for revert: Suspected the original CL cause of the bug, but proved not. Original issue's description: > Revert of Clip incremental invalidation rects for RenderBox (patchset #3 id:40001 of https://codereview.chromium.org/548523005/) > > Reason for revert: > Haven't looked into the issue deeply, but in the future we won't care about the invalidation rects, so we can just revert this kind of optimizations. > > BUG=453586 > > Original issue's description: > > Clip incremental invalidation rects for RenderBox > > > > RenderBox::incrementallyInvalidatePaint invalidates according to > > border-box delta, not considering the bounds. If the bounds are > > clipped by ancestor clipping, the incrementally invalidated rect > > may exceed the ancestor clipping. > > > > Clip the incremental invalidation rects by oldBounds and newBounds > > to avoid invalidation on unrelated areas. > > > > BUG=411420 > > TEST=fast/repaint/resize-with-border-clipped.html > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182081 > > TBR=jchaffraix@chromium.org,dsinclair@chromium.org,esprehn@chromium.org,leviw@chromium.org > BUG=411420 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189569 TBR=jchaffraix@chromium.org,dsinclair@chromium.org,esprehn@chromium.org,leviw@chromium.org BUG=453586, 456176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190682

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/resize-with-border-clipped.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/resize-with-border-clipped-expected.txt View 1 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 3 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
Created Revert of Revert of Clip incremental invalidation rects for RenderBox
5 years, 10 months ago (2015-02-23 17:48:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948513004/1
5 years, 10 months ago (2015-02-23 17:49:28 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 10 months ago (2015-02-23 17:50:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948513004/130001
5 years, 10 months ago (2015-02-23 17:58:33 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:41:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:130001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190682

Powered by Google App Engine
This is Rietveld 408576698