Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 948473002: Port GrGLCaps over to use SkTHash. (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Port GrGLCaps over to use SkTHash. I've written some new hashtable interfaces that should be easier to use, and I've been trying to roll them out bit by bit, hopefully replacing SkTDynamicHash, SkTMultiMap, SkTHashCache, etc. This turns the cache in GrGLCaps::readPixelsSupported() into an SkTHashMap, mapping the format key to a bool. Functionally, it's the same. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2aa1f7e6799501974532d35c1f6c3a0447121b95

Patch Set 1 #

Patch Set 2 : winders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -216 lines) Patch
M gyp/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkTHash.h View 3 chunks +12 lines, -0 lines 0 comments Download
D src/core/SkTHashCache.h View 1 chunk +0 lines, -77 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +13 lines, -35 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +6 lines, -13 lines 0 comments Download
M tests/HashTest.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
D tests/THashCache.cpp View 1 chunk +0 lines, -89 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mtklein_C
5 years, 10 months ago (2015-02-20 19:41:35 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-20 19:50:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948473002/1
5 years, 10 months ago (2015-02-20 19:52:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2609)
5 years, 10 months ago (2015-02-20 19:56:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948473002/20001
5 years, 10 months ago (2015-02-20 20:05:37 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:35:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2aa1f7e6799501974532d35c1f6c3a0447121b95

Powered by Google App Engine
This is Rietveld 408576698