Added Sky Mojo embedder singleton, restored network test

Added Sky Mojo embedder singleton, restored network test

Currently the embedder is just an encapsulation of the Mojo shell. Exposing an ApplicationConnection that encapsulates the ViewManager Embed SPs is next.

R=abarth@chromium.org, zra@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/934afd9213f4ea0e77a103656e788e72b5fdca4d

[hansmuller1, 2015-02-20 22:23:05]

hansmuller@google.com changed reviewers:
+ abarth@chromium.org

[hansmuller1, 2015-02-20 22:42:18]

hansmuller@google.com changed reviewers:
+ hansmuller@google.com

[hansmuller1, 2015-02-20 22:42:19]

PTAL

[hansmuller1, 2015-02-20 22:42:38]

hansmuller@google.com changed reviewers:
+ zra@google.com

[abarth-chromium, 2015-02-20 22:51:38]

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.dart
File sky/framework/embedder.dart (right):

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:12: final embedder = new EmbedderImpl();
Type pls

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:14: class EmbedderImpl {
EmbedderImpl -> _EmbedderImpl to hide the class.

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:15: final connections = new
List<ApplicationConnection>();
Type pls

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:16: var _shell;
Type pls

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:18: ShellProxy shell() {
This should be a getter.

Actually, if you make _shell final, you can get rid of this getter and rename
_shell to shell.

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:21: new
core.MojoHandle(internals.takeShellProxyHandle()));
You can do this as an initializer for _shell if you make _shell as final.

https://codereview.chromium.org/948463003/diff/20001/sky/tests/services/netwo...
File sky/tests/services/network.sky (right):

https://codereview.chromium.org/948463003/diff/20001/sky/tests/services/netwo...
sky/tests/services/network.sky:14: run(url) async {
Type pls

[hansmuller1, 2015-02-20 22:58:54]

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.dart
File sky/framework/embedder.dart (right):

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:12: final embedder = new EmbedderImpl();
On 2015/02/20 22:51:38, abarth wrote:
> Type pls

Done.

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:14: class EmbedderImpl {
On 2015/02/20 22:51:38, abarth wrote:
> EmbedderImpl -> _EmbedderImpl to hide the class.

Done.

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:15: final connections = new
List<ApplicationConnection>();
On 2015/02/20 22:51:38, abarth wrote:
> Type pls

I removed the field; it shouldn't have been there.

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:16: var _shell;
On 2015/02/20 22:51:38, abarth wrote:
> Type pls

Done.

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:18: ShellProxy shell() {
On 2015/02/20 22:51:38, abarth wrote:
> This should be a getter.
> 
> Actually, if you make _shell final, you can get rid of this getter and rename
> _shell to shell.

Done.

https://codereview.chromium.org/948463003/diff/20001/sky/framework/embedder.d...
sky/framework/embedder.dart:21: new
core.MojoHandle(internals.takeShellProxyHandle()));
On 2015/02/20 22:51:38, abarth wrote:
> You can do this as an initializer for _shell if you make _shell as final.

Done.

https://codereview.chromium.org/948463003/diff/20001/sky/tests/services/netwo...
File sky/tests/services/network.sky (right):

https://codereview.chromium.org/948463003/diff/20001/sky/tests/services/netwo...
sky/tests/services/network.sky:14: run(url) async {
On 2015/02/20 22:51:38, abarth wrote:
> Type pls

Done.

[zra, 2015-02-20 23:04:21]

lgtm with nit

https://codereview.chromium.org/948463003/diff/40001/sky/framework/embedder.dart
File sky/framework/embedder.dart (right):

https://codereview.chromium.org/948463003/diff/40001/sky/framework/embedder.d...
sky/framework/embedder.dart:16: new
core.MojoHandle(internals.takeShellProxyHandle()));
4 space indent on continued line.

[hansmuller, 2015-02-20 23:06:54]

New patchsets have been uploaded after l-g-t-m from zra@google.com

[abarth-chromium, 2015-02-20 23:07:04]

LGTM

[hansmuller, 2015-02-20 23:07:39]

Committed patchset #4 (id:60001) manually as
934afd9213f4ea0e77a103656e788e72b5fdca4d (presubmit successful).