Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2105)

Unified Diff: chrome/browser/local_discovery/privet_http_asynchronous_factory.h

Issue 948413006: Move callback and host port args into Start method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_sdc
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/local_discovery/privet_http_asynchronous_factory.h
diff --git a/chrome/browser/local_discovery/privet_http_asynchronous_factory.h b/chrome/browser/local_discovery/privet_http_asynchronous_factory.h
index 656a9461b1d17f6b5bbd7d75d0c74f556ff3d3e8..5e29562defb57baeb31ee4ade00b43aa720d8a8a 100644
--- a/chrome/browser/local_discovery/privet_http_asynchronous_factory.h
+++ b/chrome/browser/local_discovery/privet_http_asynchronous_factory.h
@@ -21,14 +21,19 @@ class PrivetHTTPClient;
class PrivetHTTPResolution {
public:
+ using ResultCallback = base::Callback<void(scoped_ptr<PrivetHTTPClient>)>;
+
virtual ~PrivetHTTPResolution() {}
- virtual void Start() = 0;
+
+ virtual void Start(const net::HostPortPair& address,
+ const ResultCallback& callback) = 0;
+
virtual const std::string& GetName() = 0;
};
class PrivetHTTPAsynchronousFactory {
public:
- typedef base::Callback<void(scoped_ptr<PrivetHTTPClient>)> ResultCallback;
+ using ResultCallback = PrivetHTTPResolution::ResultCallback;
virtual ~PrivetHTTPAsynchronousFactory() {}
@@ -36,9 +41,7 @@ class PrivetHTTPAsynchronousFactory {
net::URLRequestContextGetter* request_context);
virtual scoped_ptr<PrivetHTTPResolution> CreatePrivetHTTP(
- const std::string& name,
- const net::HostPortPair& address,
- const ResultCallback& callback) = 0;
+ const std::string& service_name) = 0;
};
} // namespace local_discovery
« no previous file with comments | « no previous file | chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698