Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 948413006: Move callback and host port args into Start method (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_sdc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move callback and host port args into Start method. Both args are not neccecary as state, so they don't need to be in the constructor. BUG=461504 Committed: https://crrev.com/712677166ccd38a780ee991e7075f637fe42cd5f Cr-Commit-Position: refs/heads/master@{#318146}

Patch Set 1 #

Patch Set 2 : Tue Feb 24 18:10:17 PST 2015 #

Patch Set 3 : Wed Feb 25 08:45:05 PST 2015 #

Patch Set 4 : Wed Feb 25 09:12:17 PST 2015 #

Patch Set 5 : #

Messages

Total messages: 13 (6 generated)
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-02-25 02:10:06 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-02-25 17:18:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948413006/80001
5 years, 10 months ago (2015-02-25 19:16:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/38388)
5 years, 10 months ago (2015-02-25 21:09:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948413006/100001
5 years, 10 months ago (2015-02-25 22:30:05 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 10 months ago (2015-02-25 23:34:06 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 23:34:44 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/712677166ccd38a780ee991e7075f637fe42cd5f
Cr-Commit-Position: refs/heads/master@{#318146}

Powered by Google App Engine
This is Rietveld 408576698