[Extensions] Make chrome://extensions use management.uninstall

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 /**
  * The type of the extension data object. The definition is based on
  * chrome/browser/ui/webui/extensions/extension_basic_info.cc
  * and
@@ skipping 214 matching lines @@
      * to prevent showExtensionNodes_ from opening the options more than once.
      * @type {boolean}
      * @private
      */
     optionsShown_: false,
 
     /** @private {!cr.ui.FocusGrid} */
     focusGrid_: new cr.ui.FocusGrid(),
 
     /**
+     * Indicates whether an uninstall dialog is being shown to prevent multiple
+     * dialogs from being displayed.
+     * @type {boolean}
+     * @private
+     */
+    uninstallIsShowing_: false,
+
+    /**
      * Necessary to only show the butterbar once.
      * @private {boolean}
      */
     butterbarShown_: false,
 
     decorate: function() {
       this.showExtensionNodes_();
     },
 
     getIdQueryParam_: function() {
@@ skipping 199 matching lines @@
 
       // 'Remove' button.
       var trashTemplate = $('template-collection').querySelector('.trash');
       var trash = trashTemplate.cloneNode(true);
       trash.title = loadTimeData.getString('extensionUninstall');
       trash.hidden = extension.managedInstall;
       trash.setAttribute('column-type', 'trash');
       trash.addEventListener('click', function(e) {
         trash.classList.add('open');
         trash.classList.toggle('mouse-clicked', e.detail > 0);
-        chrome.send('extensionSettingsUninstall', [extension.id]);
-      });
+        if (this.uninstallIsShowing_)
+          return;
+        this.uninstallIsShowing_ = true;
+        chrome.management.uninstall(extension.id,
+                                    {showConfirmDialog: true},
+                                    function() {
+          // TODO(devlin): What should we do if the uninstall fails?
+          this.uninstallIsShowing_ = false;
+        }.bind(this));
+      }.bind(this));
       row.querySelector('.enable-controls').appendChild(trash);
 
       // Developer mode ////////////////////////////////////////////////////////
 
       // The path, if provided by unpacked extension.
       row.setupColumn('.load-path a:first-of-type', 'dev-loadPath', 'click',
                       function(e) {
         chrome.send('extensionSettingsShowPath', [String(extension.id)]);
         e.preventDefault();
       });
@@ skipping 411 matching lines @@
         self.optionsShown_ = false;
         $('overlay').removeEventListener('cancelOverlay', f);
       });
 
       // TODO(dbeam): why do we need to focus <extensionoptions> before and
       // after its showing animation? Makes very little sense to me.
       overlay.setInitialFocus();
     },
   };
 
   ExtensionList.uninstallCancel = function() {

[Dan Beam, 2015/03/03 00:12:59]

dead code now :(

     var trash = document.querySelector('.trash.open');
     if (trash.classList.contains('mouse-clicked'))
       trash.blur();
     trash.classList.remove('open');
   };
 
   return {
     ExtensionList: ExtensionList
   };
 });