[Extensions] Make chrome://extensions use management.uninstall

chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/chrome_management_api_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/bookmark_app_helper.h"
 #include "chrome/browser/extensions/chrome_requirements_checker.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 56 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ManagementSetEnabledFunctionInstallPromptDelegate);
 };
 
 class ManagementUninstallFunctionUninstallDialogDelegate
     : public extensions::ExtensionUninstallDialog::Delegate,
       public extensions::UninstallDialogDelegate {
  public:
   ManagementUninstallFunctionUninstallDialogDelegate(
       extensions::ManagementUninstallFunctionBase* function,
-      const std::string& target_extension_id)
+      const extensions::Extension* target_extension,

[not at google - send to devlin, 2015/02/25 23:55:58]

Well, technically you can read the target extension from the function, so
passing them both in seems arbitrary. In fact if you added a
GetTargetExtension() function, you'd cut down on some of that other boilerplate.

However, a whole ExtensionFunction is a big bundle of state, it'd be nice if the
dependencies were tighter - just browser context, source, target, and - if you
want to be especially thorough - the bool, too (as opposed to just checking
whether the source is null).

Up to you.

[Devlin, 2015/02/26 00:19:54]

Agreed, the function is a lot of state.  But we need it, since we forward the
results of the uninstall dialog to it in ExtensionUninstallCanceled/Accepted()
(I know it's ugly, but that's not this patch's fault ;)).  We also can't just
pass in the bool, since it's not enough to know if the source extension is null
(since we show a regular uninstall for self-uninstalls).  So, we need the
function and the bool.  We could expose a GetTargetExtension() method on the
function, but that's just putting a greater dependency on passing in the
function, so I'd like to avoid it.

+      bool show_programmatic_uninstall_ui)
       : function_(function) {
-    const extensions::Extension* target_extension =
-        extensions::ExtensionRegistry::Get(function->browser_context())
-            ->GetExtensionById(target_extension_id,
-                               extensions::ExtensionRegistry::EVERYTHING);
-    content::WebContents* web_contents = function->GetAssociatedWebContents();
+    content::WebContents* web_contents = function->GetSenderWebContents();
     extension_uninstall_dialog_.reset(
         extensions::ExtensionUninstallDialog::Create(
             Profile::FromBrowserContext(function->browser_context()),
-            web_contents ? web_contents->GetTopLevelNativeWindow() : NULL,
+            web_contents ? web_contents->GetTopLevelNativeWindow() : nullptr,
             this));
-    if (function->extension_id() != target_extension_id) {
+    if (show_programmatic_uninstall_ui) {
       extension_uninstall_dialog_->ConfirmProgrammaticUninstall(
           target_extension, function->extension());
     } else {
-      // If this is a self uninstall, show the generic uninstall dialog.
       extension_uninstall_dialog_->ConfirmUninstall(target_extension);
     }
   }
   ~ManagementUninstallFunctionUninstallDialogDelegate() override {}
 
   // ExtensionUninstallDialog::Delegate implementation.
   void ExtensionUninstallAccepted() override {
     function_->ExtensionUninstallAccepted();
   }
   void ExtensionUninstallCanceled() override {
     function_->ExtensionUninstallCanceled();
   }
 
- protected:
+ private:
   extensions::ManagementUninstallFunctionBase* function_;
   scoped_ptr<extensions::ExtensionUninstallDialog> extension_uninstall_dialog_;
+
+  DISALLOW_COPY_AND_ASSIGN(ManagementUninstallFunctionUninstallDialogDelegate);
 };
 
 class ChromeAppForLinkDelegate : public extensions::AppForLinkDelegate {
  public:
   ChromeAppForLinkDelegate() {}
   ~ChromeAppForLinkDelegate() override {}
 
   void OnFaviconForApp(
       extensions::ManagementGenerateAppForLinkFunction* function,
       content::BrowserContext* context,
@@ skipping 89 matching lines @@
 }
 
 scoped_ptr<extensions::RequirementsChecker>
 ChromeManagementAPIDelegate::CreateRequirementsChecker() const {
   return make_scoped_ptr(new extensions::ChromeRequirementsChecker());
 }
 
 scoped_ptr<extensions::UninstallDialogDelegate>
 ChromeManagementAPIDelegate::UninstallFunctionDelegate(
     extensions::ManagementUninstallFunctionBase* function,
-    const std::string& target_extension_id) const {
+    const extensions::Extension* target_extension,
+    bool show_programmatic_uninstall_ui) const {
   return scoped_ptr<extensions::UninstallDialogDelegate>(
       new ManagementUninstallFunctionUninstallDialogDelegate(
-          function, target_extension_id));
+          function, target_extension, show_programmatic_uninstall_ui));
 }
 
 bool ChromeManagementAPIDelegate::CreateAppShortcutFunctionDelegate(
     extensions::ManagementCreateAppShortcutFunction* function,
     const extensions::Extension* extension) const {
   Browser* browser = chrome::FindBrowserWithProfile(
       Profile::FromBrowserContext(function->browser_context()),
       chrome::HOST_DESKTOP_TYPE_NATIVE);
   if (!browser) {
     // Shouldn't happen if we have user gesture.
@@ skipping 78 matching lines @@
 
 GURL ChromeManagementAPIDelegate::GetIconURL(
     const extensions::Extension* extension,
     int icon_size,
     ExtensionIconSet::MatchType match,
     bool grayscale,
     bool* exists) const {
   return extensions::ExtensionIconSource::GetIconURL(extension, icon_size,
                                                      match, grayscale, exists);
 }