[Extensions] Make chrome://extensions use management.uninstall

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 /**
  * The type of the extension data object. The definition is based on
  * chrome/browser/ui/webui/extensions/extension_basic_info.cc
  * and
@@ skipping 80 matching lines @@
     /**
      * Indicates whether an embedded options page that was navigated to through
      * the '?options=' URL query has been shown to the user. This is necessary
      * to prevent showExtensionNodes_ from opening the options more than once.
      * @type {boolean}
      * @private
      */
     optionsShown_: false,
 
     /**
+     * Indicates whether an uninstall dialog is being shown to prevent multiple
+     * dialogs from being displayed.
+     * @type {boolean}
+     * @private
+     */
+    uninstallShown_: false,
+
+    /**
      * Necessary to only show the butterbar once.
      * @private {boolean}
      */
     butterbarShown_: false,
 
     decorate: function() {
       this.showExtensionNodes_();
     },
 
     getIdQueryParam_: function() {
@@ skipping 170 matching lines @@
         // disabled, because the user might e.g. get prompted when enabling
         // and choose not to.
         e.preventDefault();
       });
 
       // 'Remove' button.
       var trashTemplate = $('template-collection').querySelector('.trash');
       var trash = trashTemplate.cloneNode(true);
       trash.title = loadTimeData.getString('extensionUninstall');
       trash.addEventListener('click', function(e) {
-        chrome.send('extensionSettingsUninstall', [extension.id]);
-      });
+        if (this.uninstallShown_)
+          return;
+        this.uninstallShown_ = true;

[not at google - send to devlin, 2015/02/25 21:37:57]

uninstallIsShowing would be better, Shown could mean it was shown in the past.

[Devlin, 2015/02/25 23:12:47]

Called it uninstallShown to match, e.g., optionsShown, but I'm not picky. Done.

[not at google - send to devlin, 2015/02/25 23:55:58]

Should be optionsIsShowing :P

[Devlin, 2015/02/26 00:19:54]

haha yeah, it should.

+        // TODO(devlin): What should we do if the uninstall fails?

[not at google - send to devlin, 2015/02/25 21:37:57]

TODO belongs in the callback body.

[Devlin, 2015/02/25 23:12:47]

Done.

+        chrome.management.uninstall(extension.id,
+                                    {showConfirmDialog: true},
+                                    function() {
+          this.uninstallShown_ = false;
+        }.bind(this));
+      }.bind(this));
       node.querySelector('.enable-controls').appendChild(trash);
 
       // Developer mode ////////////////////////////////////////////////////////
 
       // The path, if provided by unpacked extension.
       this.addListener_('click', node, '.load-path a:first-of-type',
                         function(e) {
         chrome.send('extensionSettingsShowPath', [String(extension.id)]);
         e.preventDefault();
       });
@@ skipping 398 matching lines @@
       // TODO(dbeam): why do we need to focus <extensionoptions> before and
       // after its showing animation? Makes very little sense to me.
       overlay.setInitialFocus();
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });