[Extensions] Make chrome://extensions use management.uninstall

chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/chrome_management_api_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/bookmark_app_helper.h"
 #include "chrome/browser/extensions/chrome_requirements_checker.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 62 matching lines @@
       public extensions::UninstallDialogDelegate {
  public:
   ManagementUninstallFunctionUninstallDialogDelegate(
       extensions::ManagementUninstallFunctionBase* function,
       const std::string& target_extension_id)
       : function_(function) {
     const extensions::Extension* target_extension =
         extensions::ExtensionRegistry::Get(function->browser_context())
             ->GetExtensionById(target_extension_id,
                                extensions::ExtensionRegistry::EVERYTHING);
-    content::WebContents* web_contents = function->GetAssociatedWebContents();
+    content::WebContents* web_contents = function->GetSenderWebContents();
     extension_uninstall_dialog_.reset(
         extensions::ExtensionUninstallDialog::Create(
             Profile::FromBrowserContext(function->browser_context()),
-            web_contents ? web_contents->GetTopLevelNativeWindow() : NULL,
+            web_contents ? web_contents->GetTopLevelNativeWindow() : nullptr,
             this));
-    if (function->extension_id() != target_extension_id) {
+    if (function->extension() &&
+        function->extension_id() != target_extension_id) {
       extension_uninstall_dialog_->ConfirmProgrammaticUninstall(
           target_extension, function->extension());
     } else {
-      // If this is a self uninstall, show the generic uninstall dialog.
+      // If this is a self uninstall, or triggered by webui (in which case

[not at google - send to devlin, 2015/02/25 21:37:57]

This decision belongs in the API implementation, not the Delegate. See comment
there.

[Devlin, 2015/02/25 23:12:47]

Done.

+      // function->extension() is null), show the generic uninstall dialog.
       extension_uninstall_dialog_->ConfirmUninstall(target_extension);
     }
   }
   ~ManagementUninstallFunctionUninstallDialogDelegate() override {}
 
   // ExtensionUninstallDialog::Delegate implementation.
   void ExtensionUninstallAccepted() override {
     function_->ExtensionUninstallAccepted();
   }
   void ExtensionUninstallCanceled() override {
     function_->ExtensionUninstallCanceled();
   }
 
- protected:
+ private:
   extensions::ManagementUninstallFunctionBase* function_;
   scoped_ptr<extensions::ExtensionUninstallDialog> extension_uninstall_dialog_;
+
+  DISALLOW_COPY_AND_ASSIGN(ManagementUninstallFunctionUninstallDialogDelegate);
 };
 
 class ChromeAppForLinkDelegate : public extensions::AppForLinkDelegate {
  public:
   ChromeAppForLinkDelegate() {}
   ~ChromeAppForLinkDelegate() override {}
 
   void OnFaviconForApp(
       extensions::ManagementGenerateAppForLinkFunction* function,
       content::BrowserContext* context,
@@ skipping 191 matching lines @@
 
 GURL ChromeManagementAPIDelegate::GetIconURL(
     const extensions::Extension* extension,
     int icon_size,
     ExtensionIconSet::MatchType match,
     bool grayscale,
     bool* exists) const {
   return extensions::ExtensionIconSource::GetIconURL(extension, icon_size,
                                                      match, grayscale, exists);
 }