Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 948383003: Force slow objects for select objects during startup. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index 9d5be9da87f9d2fcd7221bb7c1c31535c25d9b32..a7b3e56d88b01d8ab2c303cc5b62afdb43d9b4ca 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -331,14 +331,13 @@ class OldEmitter implements Emitter {
var field = generateAccessor(fields[i], accessors, name);
if (#hasIsolateSupport) { fieldNames += "'" + field + "',"; }
- var parameter = "parameter_" + field;
+ var parameter = "p_" + field;
str += parameter;
body += ("this." + field + " = " + parameter + ";\n");
}
str += ") {\n" + body + "}\n";
str += name + ".builtin$cls=\"" + name + "\";\n";
- str += "$desc=$collectedClasses." + name + ";\n";
- str += "if($desc instanceof Array) $desc = \$desc[1];\n";
+ str += "$desc=$collectedClasses." + name + "[1];\n";
str += name + ".prototype = $desc;\n";
if (typeof defineClass.name != "string") {
str += name + ".name=\"" + name + "\";\n";
@@ -426,6 +425,7 @@ class OldEmitter implements Emitter {
return function (constructor, superConstructor) {
tmp.prototype = superConstructor.prototype;
var object = new tmp();
+ object.x = 0; delete object.x; // Make object slow.
floitsch 2015/02/24 20:21:39 I discussed and benchmarked this with Slava. It lo
herhut 2015/03/09 15:11:05 Acknowledged.
var properties = constructor.prototype;
var members = Object.keys(properties);
for (var i = 0; i < members.length; i++) {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698