Issue 948343007: Get text align in elf writer from the target asm method instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 948343007: Get text align in elf writer from the target asm method instead. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)

Modified:
5 years, 10 months ago

Reviewers:
Karl, Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/IceELFObjectWriter.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

LGTM. And I couldn't find any more suspicious uses of "32" or "5" in the ...

5 years, 10 months ago (2015-02-25 14:16:03 UTC) #3

jvoung (off chromium)

5 years, 10 months ago (2015-02-25 17:08:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e9079cb8eefe8bf315bb25d9e37c4f347f0dc7f4 (presubmit successful).