Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp

Issue 94833002: Remove usage of deprecated V8 APIs from bindings code generator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp b/Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp
index 3698f67d5353149edc9703db7fc1154249014e7a..24c03ec5ffaac25e688d0c71919c844168d700c2 100644
--- a/Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp
+++ b/Source/bindings/tests/results/V8TestCustomLegacyCallInterface.cpp
@@ -91,7 +91,7 @@ static v8::Handle<v8::FunctionTemplate> ConfigureV8TestCustomLegacyCallInterface
functionTemplate->InstanceTemplate()->SetCallAsFunctionHandler(V8TestCustomLegacyCallInterface::legacyCallCustom);
// Custom toString template
- functionTemplate->Set(v8::String::NewSymbol("toString"), V8PerIsolateData::current()->toStringTemplate());
+ functionTemplate->Set(v8::String::NewFromUtf8(isolate, "toString", v8::String::kInternalizedString), V8PerIsolateData::current()->toStringTemplate());
return functionTemplate;
}
@@ -103,11 +103,11 @@ v8::Handle<v8::FunctionTemplate> V8TestCustomLegacyCallInterface::GetTemplate(v8
return result->value.newLocal(isolate);
TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "BuildDOMTemplate");
- v8::HandleScope handleScope(isolate);
- v8::Handle<v8::FunctionTemplate> templ =
+ v8::EscapableHandleScope handleScope(isolate);
+ v8::Local<v8::FunctionTemplate> templ =
ConfigureV8TestCustomLegacyCallInterfaceTemplate(data->rawTemplate(&wrapperTypeInfo, currentWorldType), isolate, currentWorldType);
data->templateMap(currentWorldType).add(&wrapperTypeInfo, UnsafePersistent<v8::FunctionTemplate>(isolate, templ));
- return handleScope.Close(templ);
+ return handleScope.Escape(templ);
}
bool V8TestCustomLegacyCallInterface::hasInstance(v8::Handle<v8::Value> jsValue, v8::Isolate* isolate, WrapperWorldType currentWorldType)

Powered by Google App Engine
This is Rietveld 408576698