Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 948323003: Fix the definition of the 'blink_tests' target in build/all.gyp. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the definition of the 'blink_tests' target in build/all.gyp. The change in #317893 accidentally made the blink_tests target not exist in an Android build. That was bad :). TBR=alancutter@chromium.org NOTRY=true Committed: https://crrev.com/73638aacdada58d8dab3529c516a4e32c4e07a51 Cr-Commit-Position: refs/heads/master@{#317907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dirk Pranke
5 years, 10 months ago (2015-02-24 22:44:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948323003/1
5 years, 10 months ago (2015-02-24 22:44:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 22:45:20 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 22:46:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73638aacdada58d8dab3529c516a4e32c4e07a51
Cr-Commit-Position: refs/heads/master@{#317907}

Powered by Google App Engine
This is Rietveld 408576698