Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Unified Diff: content/public/browser/content_browser_client.h

Issue 948293002: Add RAPPOR metrics of ServiceWorker.ControlledPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: RecordURLMetric Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.cc ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index fbe8214fd2462901e9ebf31f5630974233bfb58a..550d42a671e928a06bbda767ce8e098ead057440 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -626,6 +626,9 @@ class CONTENT_EXPORT ContentBrowserClient {
const OpenURLParams& params,
const base::Callback<void(WebContents*)>& callback);
+ // Records the url to collect the metric.
nasko 2015/02/26 14:52:44 Let's follow the style of comments already present
horo 2015/02/27 00:59:14 Done.
+ virtual void RecordURLMetric(const std::string& metric, const GURL& gurl) {}
nasko 2015/02/26 14:52:44 nit: s/gurl/url/
horo 2015/02/27 00:59:14 Done.
+
#if defined(OS_POSIX) && !defined(OS_MACOSX)
// Populates |mappings| with all files that need to be mapped before launching
// a child process.
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.cc ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698