Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 948293002: Add RAPPOR metrics of ServiceWorker.ControlledPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated falken's comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index 6e3ddf1d7aaded7762fd92449e45077a38047d8d..d984384988248f3a051d87a21d207a8a7eea8f8f 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -6,10 +6,24 @@
#include "base/metrics/histogram.h"
#include "base/metrics/user_metrics_action.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/user_metrics.h"
+#include "content/public/common/content_client.h"
namespace content {
+namespace {
+
+void SampleDomainAndRegistryFromGURLOnUI(const GURL& url) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ GetContentClient()->browser()->SampleDomainAndRegistryFromGURL(
+ "ServiceWorker.ControlledPage",
falken 2015/02/25 03:36:58 just bikeshedding now... "ControlledPageUrl" would
horo 2015/02/25 04:30:04 Done.
+ url);
+}
+
+} // namespace
+
// static
void ServiceWorkerMetrics::CountInitDiskCacheResult(bool result) {
UMA_HISTOGRAM_BOOLEAN("ServiceWorker.DiskCache.InitResult", result);
@@ -51,8 +65,12 @@ void ServiceWorkerMetrics::CountWriteDatabaseResult(
}
// static
-void ServiceWorkerMetrics::CountControlledPageLoad() {
+void ServiceWorkerMetrics::CountControlledPageLoad(const GURL& url) {
RecordAction(base::UserMetricsAction("ServiceWorker.ControlledPageLoad"));
+ BrowserThread::PostTask(
+ BrowserThread::UI,
+ FROM_HERE,
+ base::Bind(&SampleDomainAndRegistryFromGURLOnUI, url));
}
} // namespace content
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.h ('k') | content/public/browser/content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698