content/browser/service_worker/service_worker_controllee_request_handler.cc - Issue 948293002: Add RAPPOR metrics of ServiceWorker.ControlledPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 948293002: Add RAPPOR metrics of ServiceWorker.ControlledPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated nasko's comment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_controllee_request_handler.h ('k') | content/browser/service_worker/service_worker_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_controllee_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc

index b56dd3f422e26a8157edb232ae3b6d0684ee7e7b..4e297345990bb15349fa45485fdba5af120c795a 100644

--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc

+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc

@@ -156,13 +156,12 @@ void ServiceWorkerControlleeRequestHandler::PrepareForMainResource(

// registration while we're finding an existing registration.

provider_host_->SetAllowAssociation(false);

- GURL stripped_url = net::SimplifyUrlForRequest(request->url());

- provider_host_->SetDocumentUrl(stripped_url);

+ stripped_url_ = net::SimplifyUrlForRequest(request->url());

+ provider_host_->SetDocumentUrl(stripped_url_);

provider_host_->SetTopmostFrameUrl(request->first_party_for_cookies());

context_->storage()->FindRegistrationForDocument(

- stripped_url,

- base::Bind(&self::DidLookupRegistrationForMainResource,

- weak_factory_.GetWeakPtr()));

+ stripped_url_, base::Bind(&self::DidLookupRegistrationForMainResource,

+ weak_factory_.GetWeakPtr()));

}

void

@@ -238,7 +237,7 @@ ServiceWorkerControlleeRequestHandler::DidLookupRegistrationForMainResource(

return;

}

- ServiceWorkerMetrics::CountControlledPageLoad();

+ ServiceWorkerMetrics::CountControlledPageLoad(stripped_url_);

provider_host_->AssociateRegistration(registration.get());

job_->ForwardToServiceWorker();

@@ -263,7 +262,7 @@ void ServiceWorkerControlleeRequestHandler::OnVersionStatusChanged(

return;

}

- ServiceWorkerMetrics::CountControlledPageLoad();

+ ServiceWorkerMetrics::CountControlledPageLoad(stripped_url_);

provider_host_->AssociateRegistration(registration);

job_->ForwardToServiceWorker();