Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 948283005: Added PrivetHTTPResolution::Start for service name only (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_start
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added PrivetHTTPResolution::Start for service name only Host:port can be resolved from service name. Still old method is useful when client already know them. BUG=461504 Committed: https://crrev.com/47f1b8cd0c50323b2577c44e7286a3eb26e22cbb Cr-Commit-Position: refs/heads/master@{#318157}

Patch Set 1 #

Patch Set 2 : Tue Feb 24 18:35:08 PST 2015 #

Patch Set 3 : Wed Feb 25 15:43:16 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M chrome/browser/local_discovery/privet_http_asynchronous_factory.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-02-25 02:37:01 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-02-25 02:41:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948283005/20001
5 years, 10 months ago (2015-02-25 02:41:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/61885)
5 years, 10 months ago (2015-02-25 02:47:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948283005/40001
5 years, 10 months ago (2015-02-25 23:45:42 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-26 00:35:35 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 00:36:48 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47f1b8cd0c50323b2577c44e7286a3eb26e22cbb
Cr-Commit-Position: refs/heads/master@{#318157}

Powered by Google App Engine
This is Rietveld 408576698