Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 948243006: Unchecking the "Surprise Me" checkbox should go back previous wallpaper before "Surprise Me" was tu… (Closed)

Created:
5 years, 10 months ago by xdai1
Modified:
5 years, 10 months ago
Reviewers:
bshe
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unchecking the "Surprise Me" checkbox should go back previous wallpaper before "Surprise Me" was turned on. BUG=316692 TEST=Manually tested Committed: https://crrev.com/18845db7c39c4850abc32dbaef4cacd42aba1dec Cr-Commit-Position: refs/heads/master@{#318116}

Patch Set 1 #

Patch Set 2 : Please review from this patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js View 1 5 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xdai1
Biao, can you help to review the CL please? Thanks!
5 years, 10 months ago (2015-02-24 18:05:41 UTC) #2
xdai1
On 2015/02/24 18:05:41, xdai1 wrote: > Biao, can you help to review the CL please? ...
5 years, 10 months ago (2015-02-25 19:03:08 UTC) #4
bshe
sorry for the delay. lgtm
5 years, 10 months ago (2015-02-25 20:00:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948243006/40001
5 years, 10 months ago (2015-02-25 21:14:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-25 21:17:24 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 21:18:59 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/18845db7c39c4850abc32dbaef4cacd42aba1dec
Cr-Commit-Position: refs/heads/master@{#318116}

Powered by Google App Engine
This is Rietveld 408576698