Merge custom bindings for context menus

chrome/browser/extensions/extension_context_menu_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/lazy_background_page_test_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
@@ skipping 197 matching lines @@
 
   // Look for the extension item in the menu, and execute it.
   int command_id = ContextMenuMatcher::ConvertToExtensionsCustomCommandId(0);
   ASSERT_TRUE(menu->IsCommandIdEnabled(command_id));
   menu->ExecuteCommand(command_id, 0);
 
   // Wait for the extension's script to tell us its onclick fired.
   ASSERT_TRUE(listener2.WaitUntilSatisfied());
 }
 
+// Tests that previous onclick is not fired after updating the menu's onclick.

[lazyboy, 2015/02/26 00:39:47]

// This test also tests that setting onclick handler explicitly to null removes
the handler.

[robwu, 2015/02/26 09:33:46]

Done.

+IN_PROC_BROWSER_TEST_F(ExtensionContextMenuBrowserTest, UpdateOnclick) {
+  ExtensionTestMessageListener listener_error1("onclick-unexpected", false);

[lazyboy, 2015/02/26 00:39:47]

"onclick1-unexpected", let's append 1 in all places where it refers to first
menu item.
id->id1 in js

[robwu, 2015/02/26 09:33:46]

Done.

+  ExtensionTestMessageListener listener_error2("onclick2-unexpected", false);
+  ExtensionTestMessageListener listener_update1("update1", true);
+  ExtensionTestMessageListener listener_update2("update2", false);
+  ExtensionTestMessageListener listener_done("onclick2", false);
+  ASSERT_TRUE(LoadContextMenuExtension("onclick_null"));
+
+  // Wait till item has been created and updated.
+  ASSERT_TRUE(listener_update1.WaitUntilSatisfied());
+
+  GURL page_url("http://www.google.com");
+
+  // Create and build our test context menu.
+  scoped_ptr<TestRenderViewContextMenu> menu(TestRenderViewContextMenu::Create(
+      GetWebContents(), page_url, GURL(), GURL()));
+
+  // Look for the extension item in the menu, and execute it.
+  int command_id = ContextMenuMatcher::ConvertToExtensionsCustomCommandId(0);
+  ASSERT_TRUE(menu->IsCommandIdEnabled(command_id));
+  menu->ExecuteCommand(command_id, 0);
+
+  // Let the test proceed.
+  listener_update1.Reply("");
+
+  // Wait until the second context menu has been set up.
+  ASSERT_TRUE(listener_update2.WaitUntilSatisfied());
+
+  // Click on the second menu item.
+  command_id = ContextMenuMatcher::ConvertToExtensionsCustomCommandId(1);
+  ASSERT_TRUE(menu->IsCommandIdEnabled(command_id));
+  menu->ExecuteCommand(command_id, 0);
+  ASSERT_TRUE(listener_done.WaitUntilSatisfied());
+
+  // Upon completion, the replaced onclick callbacks should not have fired.
+  ASSERT_FALSE(listener_error1.was_satisfied());
+  ASSERT_FALSE(listener_error2.was_satisfied());
+}
+
 // Tests that setting "documentUrlPatterns" for an item properly restricts
 // those items to matching pages.
 IN_PROC_BROWSER_TEST_F(ExtensionContextMenuBrowserTest, Patterns) {
   ExtensionTestMessageListener listener("created items", false);
 
   ASSERT_TRUE(LoadContextMenuExtension("patterns"));
 
   // Wait for the js test code to create its two items with patterns.
   ASSERT_TRUE(listener.WaitUntilSatisfied());
 
@@ skipping 377 matching lines @@
   ASSERT_TRUE(LoadContextMenuExtensionIncognito("incognito"));
 
   // Wait for the extension's processes to tell us they've created an item.
   ASSERT_TRUE(created.WaitUntilSatisfied());
   ASSERT_TRUE(created_incognito.WaitUntilSatisfied());
   ASSERT_EQ(2u, GetItems().size());
 
   browser()->profile()->DestroyOffTheRecordProfile();
   ASSERT_EQ(1u, GetItems().size());
 }