Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 948223002: Reland "ui: Add another presubmit check to catch two more scoped_ptr usages." (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
M-A Ruel, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "ui: Add another presubmit check to catch two more scoped_ptr usages." BUG=None TEST=git cl presubmit -uv TBR=maruel@chromium.org,sky@chromium.org Committed: https://crrev.com/ecf4c15e342616bddbb35f80f93c864ad35cbf76 Cr-Commit-Position: refs/heads/master@{#317724}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M ui/PRESUBMIT.py View 1 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948223002/40001
5 years, 10 months ago (2015-02-24 00:30:34 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-24 01:33:05 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:33:48 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ecf4c15e342616bddbb35f80f93c864ad35cbf76
Cr-Commit-Position: refs/heads/master@{#317724}

Powered by Google App Engine
This is Rietveld 408576698