Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3499)

Issue 948183003: Disable alpha, translate animations in the app menu for ICS. (Closed)

Created:
5 years, 10 months ago by Ted C
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable alpha, translate animations in the app menu for ICS. The performance is horrendous, so let's disable the animations for each of the menu items for now as it looks 90% as good as a well performing animation on newer builds of android. BUG=428477 Committed: https://crrev.com/b86e971fc043def71c71fd62ea98516e451aac28 Cr-Commit-Position: refs/heads/master@{#317692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
5 years, 10 months ago (2015-02-23 23:14:18 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 10 months ago (2015-02-23 23:42:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948183003/1
5 years, 10 months ago (2015-02-23 23:52:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 00:40:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 00:40:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b86e971fc043def71c71fd62ea98516e451aac28
Cr-Commit-Position: refs/heads/master@{#317692}

Powered by Google App Engine
This is Rietveld 408576698