Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 948143003: Mark //testing/perf target testonly. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, Nico, tonyg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark //testing/perf target testonly. That should prevent it from be used in production code. BUG=280157 R=brettw@chromium.org Committed: https://crrev.com/c39790a99ebaa6c73671de3f6837e820dcc65a1f Cr-Commit-Position: refs/heads/master@{#317726}

Patch Set 1 #

Patch Set 2 : browser should not need //testing/perf dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M testing/perf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tfarina
Followup to https://codereview.chromium.org/946873002/#msg10
5 years, 10 months ago (2015-02-23 21:27:54 UTC) #1
brettw
lgtm
5 years, 10 months ago (2015-02-23 21:28:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948143003/1
5 years, 10 months ago (2015-02-23 21:29:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/45506) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 10 months ago (2015-02-23 21:47:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948143003/20001
5 years, 10 months ago (2015-02-24 00:24:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 01:34:46 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:35:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c39790a99ebaa6c73671de3f6837e820dcc65a1f
Cr-Commit-Position: refs/heads/master@{#317726}

Powered by Google App Engine
This is Rietveld 408576698