Remove unused WebFrame::swap() path for local frames.

Remove unused WebFrame::swap() path for local frames.

All local frames being swapped in must be provisional local frames. The
other code path is completely unexercised outside of some unit tests.
Once the PlzNavigate work is closer to completion, the non-provisional
local frame path can be reintroduced and properly tested.

BUG=346764
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190715

[dcheng, 2015-02-23 21:05:12]

dcheng@chromium.org changed reviewers:
+ alexmos@chromium.org, haraken@chromium.org

[dcheng, 2015-02-23 21:05:12]

+haraken, mind doing the overall review for this? I'm happy to answer any
questions you might have. Unfortunately, I'm in EST atm but I'll be around later
tonight.

+alexmos, you might also be interested in these changes =)

https://codereview.chromium.org/948143002/diff/20001/Source/web/WebLocalFrame...
File Source/web/WebLocalFrameImpl.cpp (left):

https://codereview.chromium.org/948143002/diff/20001/Source/web/WebLocalFrame...
Source/web/WebLocalFrameImpl.cpp:1860: OwnPtrWillBePersistent<FrameOwner>
tempOwner = RemoteBridgeFrameOwner::create(nullptr, SandboxNone);
Btw, is there ever a reason we'd want a stack Persistent? This seems like
something that the Oilpan plugin should warn about.

[haraken, 2015-02-24 00:09:07]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[haraken, 2015-02-24 00:09:07]

LGTM

https://codereview.chromium.org/948143002/diff/20001/Source/web/WebLocalFrame...
File Source/web/WebLocalFrameImpl.cpp (left):

https://codereview.chromium.org/948143002/diff/20001/Source/web/WebLocalFrame...
Source/web/WebLocalFrameImpl.cpp:1860: OwnPtrWillBePersistent<FrameOwner>
tempOwner = RemoteBridgeFrameOwner::create(nullptr, SandboxNone);
On 2015/02/23 21:05:12, dcheng wrote:
> Btw, is there ever a reason we'd want a stack Persistent? This seems like
> something that the Oilpan plugin should warn about.

OwnPtrWillBeRawPtr is a right pointer here.

In unit tests, we sometimes need to use persistent handles for on-stack pointers
to protect the pointers from getting collected by
Heap::collectGarbage(NoHeapPointersOnStack) (we use NoHeapPointersOnStack to
make the behavior deterministic (i.e., not conservative)). However, this happens
only in unit tests (*Test.cpp), so I agree that we should improve the plugin to
detect this kind of error.

[dcheng, 2015-02-24 02:14:35]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-02-24 02:15:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/948143002/20001

[commit-bot: I haz the power, 2015-02-24 05:13:36]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190715