Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: tools/testing/dart/status_reporter.dart

Issue 948113003: Add a --simple flag to status_reporter to allow a fast build covering important configurations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/status_reporter.dart
diff --git a/tools/testing/dart/status_reporter.dart b/tools/testing/dart/status_reporter.dart
index c031cd19d46a4f406f5133ee182b57340890a93e..80d8f9e0f4770edd8c2e6e2c5013bc273115eef2 100644
--- a/tools/testing/dart/status_reporter.dart
+++ b/tools/testing/dart/status_reporter.dart
@@ -90,14 +90,21 @@ List<Map> getCombinations() {
return COMBINATIONS[Platform.operatingSystem];
}
-void ensureBuild(Iterable<String> archs) {
+void ensureBuild(Iterable<String> modes, Iterable<String> archs) {
print('Building many platforms. Please be patient.');
var archString = '-a${archs.join(',')}';
- var args = ['tools/build.py', '-mrelease,debug', archString, 'create_sdk',
+ var modeString = '-m${modes.join(',')}';
+
+ var args = [
+ 'tools/build.py',
+ modeString,
+ archString,
+ 'create_sdk',
// We build runtime to be able to list cc tests
- 'runtime'];
+ 'runtime'
+ ];
print('Running: python ${args.join(" ")}');
@@ -134,17 +141,33 @@ void sanityCheck(String output) {
void main(List<String> args) {
var combinations = getCombinations();
- var arches = combinations.fold(new Set<String>(), (set, value) {
- set.addAll(value['archs']);
- return set;
- });
+ var arches = new Set<String>();
+ var modes = new Set<String>();
+
+ if (args.contains('--simple')) {
+ arches = ['ia32'].toSet();
+ modes = ['release'].toSet();
+ } else {
+ for (var combo in combinations) {
+ arches.addAll(combo['archs']);
+ modes.addAll(combo['modes']);
+ }
+ }
- ensureBuild(arches);
+ ensureBuild(modes, arches);
List<String> keys;
for (var combination in combinations) {
for (var mode in combination['modes']) {
ricow1 2015/02/27 10:34:56 why not just iterate modes?
kevmoo 2015/02/27 12:11:23 Because each combo may have a subset of all modes.
+ if (!modes.contains(mode)) {
+ break;
ricow1 2015/03/02 07:43:42 don't you mean continue? I assume this just works
+ }
+
for (var arch in combination['archs']) {
ricow1 2015/02/27 10:34:56 why not just iterate arches?
kevmoo 2015/02/27 12:11:23 Ditto :-)
+ if (!arches.contains(arch)) {
+ break;
+ }
+
for (var runtime in combination['runtimes']) {
var compiler = combination['compiler'];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698