Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 948073002: Fix typos in sky-drawer and sky-scrollable (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix typos in sky-drawer and sky-scrollable Now that I can test these with a touch device, I found a few runtime errors that are fixed in this CL. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9856668299fd1e71d289b6fc044b8ea535734fa7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M sky/framework/fling-curve.dart View 1 chunk +7 lines, -3 lines 0 comments Download
M sky/framework/sky-drawer.sky View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/framework/sky-scrollable.sky View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-23 18:06:39 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-23 18:11:01 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-02-23 18:12:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9856668299fd1e71d289b6fc044b8ea535734fa7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698