Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: trunk/Source/core/frame/FrameView.cpp

Issue 948053002: Revert 190605 "Make RenderObject::style() return a const object" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/Source/core/frame/FrameView.cpp
===================================================================
--- trunk/Source/core/frame/FrameView.cpp (revision 190671)
+++ trunk/Source/core/frame/FrameView.cpp (working copy)
@@ -1297,15 +1297,15 @@
for (const auto& viewportConstrainedObject : *m_viewportConstrainedObjects) {
LayoutObject* renderer = viewportConstrainedObject;
- const LayoutStyle& style = renderer->styleRef();
+ LayoutStyle* style = renderer->style();
if (widthChanged) {
- if (style.width().isFixed() && (style.left().isAuto() || style.right().isAuto()))
+ if (style->width().isFixed() && (style->left().isAuto() || style->right().isAuto()))
renderer->setNeedsPositionedMovementLayout();
else
renderer->setNeedsLayoutAndFullPaintInvalidation();
}
if (heightChanged) {
- if (style.height().isFixed() && (style.top().isAuto() || style.bottom().isAuto()))
+ if (style->height().isFixed() && (style->top().isAuto() || style->bottom().isAuto()))
renderer->setNeedsPositionedMovementLayout();
else
renderer->setNeedsLayoutAndFullPaintInvalidation();
« no previous file with comments | « trunk/Source/core/editing/iterators/TextIterator.cpp ('k') | trunk/Source/core/html/HTMLFormControlElementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698