Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 948053002: Revert 190605 "Make RenderObject::style() return a const object" (Closed)

Created:
5 years, 10 months ago by Julien - ping for review
Modified:
5 years, 10 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert 190605 "Make RenderObject::style() return a const object" The change may have caused a bad crasher on Canary. > Make RenderObject::style() return a const object > > The current code was sloppy and allowed accidental mutation > of RenderStyle outside of style recalc. While this change > doesn't fix that class of bugs (as we introduce some > mutable accessors), it greatly reduces the risk of > them being introduced by mistake. > > In order to make the change work, 2 fields on RenderStyle had > to be made mutable (unique and explicitInheritance) because > they are propagated up the tree during style recalc. > > Also StyleSelectorState had to be changed to store the override > parent style independently of the regular parent style. That's > required as RefPtr modifies the style by increasing the refCount > and we have to hold onto the override as it can be a free style. > > Review URL: https://codereview.chromium.org/889563002 TBR=jchaffraix@chromium.org BUG=460820 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -224 lines) Patch
M trunk/Source/core/animation/DocumentAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/animation/css/CSSAnimations.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/animation/css/CSSAnimations.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/css/CSSGradientValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/css/SelectorChecker.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/css/resolver/ElementResolveContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/css/resolver/ElementResolveContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/css/resolver/SharedStyleFinder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/css/resolver/StyleResolver.h View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/core/css/resolver/StyleResolver.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M trunk/Source/core/css/resolver/StyleResolverState.h View 4 chunks +7 lines, -12 lines 0 comments Download
M trunk/Source/core/css/resolver/StyleResolverState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/dom/Document.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M trunk/Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/dom/Element.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/Source/core/dom/FirstLetterPseudoElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/dom/Node.h View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/dom/NodeLayoutStyle.h View 2 chunks +3 lines, -8 lines 0 comments Download
M trunk/Source/core/dom/PseudoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/dom/RenderTreeBuilder.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/dom/Text.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/dom/TreeScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/editing/ApplyBlockElementCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/Source/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/editing/SimplifyMarkupCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/editing/VisibleUnits.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/editing/iterators/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/frame/FrameView.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/forms/InputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/html/shadow/SliderThumbElement.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/layout/LayoutMedia.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/layout/LayoutObject.h View 3 chunks +5 lines, -6 lines 0 comments Download
M trunk/Source/core/layout/LayoutObject.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/layout/LayoutObjectInlines.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/layout/LayoutQuote.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/layout/LayoutSliderContainer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/core/layout/LayoutSliderThumb.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M trunk/Source/core/layout/LayoutTextControl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/layout/LayoutTextControlMultiLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/layout/LayoutTextControlSingleLine.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M trunk/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/layout/style/LayoutStyle.h View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/Source/core/layout/style/LayoutStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/page/TouchAdjustment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/rendering/RenderBlock.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M trunk/Source/core/rendering/RenderCombineText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/rendering/RenderInline.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/rendering/RenderListMarker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/core/rendering/RenderMenuList.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/core/svg/SVGElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/svg/SVGElementRareData.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/svg/SVGElementRareData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/svg/SVGFEFloodElement.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M trunk/Source/core/svg/SVGGraphicsElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/core/svg/SVGLengthContext.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/Source/core/svg/SVGStopElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/accessibility/AXRenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/accessibility/AXSlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/accessibility/AXTable.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/web/WebFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/web/mac/WebSubstringUtil.mm View 1 chunk +7 lines, -7 lines 0 comments Download
M trunk/Source/web/tests/WebDocumentTest.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M trunk/Source/web/tests/WebFrameTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Julien - ping for review
5 years, 10 months ago (2015-02-23 17:40:38 UTC) #1
Julien - ping for review
5 years, 10 months ago (2015-02-23 17:40:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r190673.

Powered by Google App Engine
This is Rietveld 408576698