Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 948043003: Fix to check for inf when generating quadratic points (Closed)

Created:
5 years, 10 months ago by egdaniel
Modified:
5 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix to check for inf when generating quadratic points BUG=skia:3453 Committed: https://skia.googlesource.com/skia/+/5a23a14b1fbc7503bdeff83e4b45ae7c258c6e96

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M gm/conicpaths.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M src/core/SkPoint.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 1 2 chunks +26 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
egdaniel
Local testing shows that the change to the GM causes us to assert before the ...
5 years, 10 months ago (2015-02-23 16:49:34 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-23 19:35:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948043003/20001
5 years, 10 months ago (2015-02-25 14:34:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 14:41:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5a23a14b1fbc7503bdeff83e4b45ae7c258c6e96

Powered by Google App Engine
This is Rietveld 408576698