Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 948013002: When sanitizing serialized navigation entries also take iframes into account (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
marja
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When sanitizing serialized navigation entries also take iframes into account The state of the iframes is encoded in the page state, so we need to decode the page state and recursively check it. BUG=422871 R=marja@chromium.org Committed: https://crrev.com/7b6465936e610ec9b452446ca4c4718d07f4095c Cr-Commit-Position: refs/heads/master@{#317595}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M components/sessions/content/content_serialized_navigation_driver.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/public/common/page_state.cc View 3 chunks +30 lines, -1 line 2 comments Download

Messages

Total messages: 12 (3 generated)
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-23 15:13:00 UTC) #1
marja
lgtm https://codereview.chromium.org/948013002/diff/1/content/public/common/page_state.cc File content/public/common/page_state.cc (right): https://codereview.chromium.org/948013002/diff/1/content/public/common/page_state.cc#newcode136 content/public/common/page_state.cc:136: if (!DecodePageState(data_, &state)) What happens to data_ here? ...
5 years, 10 months ago (2015-02-23 15:30:04 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/948013002/diff/1/content/public/common/page_state.cc File content/public/common/page_state.cc (right): https://codereview.chromium.org/948013002/diff/1/content/public/common/page_state.cc#newcode136 content/public/common/page_state.cc:136: if (!DecodePageState(data_, &state)) On 2015/02/23 15:30:04, marja wrote: > ...
5 years, 10 months ago (2015-02-23 16:20:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948013002/1
5 years, 10 months ago (2015-02-23 16:26:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61666)
5 years, 10 months ago (2015-02-23 16:29:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948013002/1
5 years, 10 months ago (2015-02-23 16:43:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 16:55:47 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7b6465936e610ec9b452446ca4c4718d07f4095c Cr-Commit-Position: refs/heads/master@{#317595}
5 years, 10 months ago (2015-02-23 16:56:36 UTC) #11
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-24 09:43:58 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/952783003/ by jochen@chromium.org.

The reason for reverting is: regresses startup performance too much.

Powered by Google App Engine
This is Rietveld 408576698